Signal sRGB correctly in HEIF and AVIF NCLX profiles - #458
Open
gregbenz wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gregbenz
marked this pull request as ready for review
August 18, 2026 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal sRGB correctly in HEIF and AVIF NCLX profiles
Summary
Why
The HEIF/AVIF encoding APIs require the SDR intent to use
UHDR_CT_SRGB, but the output NCLX profile currently identifies that transfer as BT.709. This conflicts with the sRGB pixel encoding and the sRGB ICC profile written by the same path.Viewers that honor NCLX may therefore select the BT.709 inverse transfer function for sRGB values, producing incorrect linear-light values that are most noticeable in shadows. The encoded pixels are unchanged by this fix; only their transfer-characteristic signaling is corrected.
The decoder retains BT.709 as a legacy alias for sRGB so files written by existing libultrahdr releases remain compatible.
Testing