Return after rejecting invalid encoder inputs - #444
Open
gregbenz wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
DichenZhang1
approved these changes
Aug 14, 2026
gregbenz
force-pushed
the
codex/fix-invalid-encoder-setters
branch
from
August 15, 2026 01:34
1ef1d00 to
02f3fd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Both setters currently construct an error but continue executing. An invalid brightness
is stored in the encoder, and an otherwise valid JPEG with an invalid intent is accepted
under that intent while the API reports success. Returning the validation error keeps
rejected input out of encoder state and makes the public API result trustworthy.
Testing
both fail on current main and pass with this change.
combinations skipped.