Fix infinite loops in cycle finder. - #2834
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
This change fixes several infinite loop conditions in cycle finder: 1. Adds loop detection in GraphBuilder.addSuperclassEdges to prevent infinite loops when type hierarchies have cycles. 2. Fixes ReferenceGraph.findShortestCycle to terminate if there are no more nodes to visit, returning an empty list. 3. Fixes CycleFinder.handleStronglyConnectedComponent to skip cycle extraction and remove the root from unused types if findShortestCycle returns an empty list. PiperOrigin-RevId: 964969489
copybara-service
Bot
force-pushed
the
test_964969489
branch
from
August 20, 2026 19:09
af3d6b8 to
a79e365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix infinite loops in cycle finder.
This change fixes several infinite loop conditions in cycle finder: