Repository navigation
Return ENOENT for missing original destinations - #15279
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl992760181
branch
13 times, most recently
from
October 6, 2026 01:27
5a87cf4 to
4b92463
Compare
Match Linux's SO_ORIGINAL_DST result when conntrack has no matching connection [1]. Both the uninitialized-table guard and an initialized conntrack lookup returned ENOTCONN. The guard and syscall expectation introduced in b3ff31d prevented a panic but used the wrong errno. Return the existing ENOENT error from both lookup paths. Extend the NAT reaping test to verify the original destination while tracked and the missing-connection error after reaping. Correct the syscall expectation, close its socket through FileDescriptor, and remove the unrelated raw socket capability requirement from this TCP query. [1]: https://github.com/torvalds/linux/blob/830b3c68c/net/netfilter/nf_conntrack_proto.c#L254-L307 Assisted-by: OpenAI Codex <!-- codex-thread: 01a0680f-bbf5-7511-95f7-4414f4e10d2e --> FUTURE_COPYBARA_INTEGRATE_REVIEW=#15169 from tamird:original-dst-missing-connection d601665 PiperOrigin-RevId: 992760181
copybara-service
Bot
force-pushed
the
test/cl992760181
branch
from
October 6, 2026 03:12
4b92463 to
4927245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return ENOENT for missing original destinations
Match Linux's SO_ORIGINAL_DST result when conntrack has no matching connection 1. Both the uninitialized-table guard and an initialized conntrack lookup returned ENOTCONN. The guard and syscall expectation introduced in b3ff31d prevented a panic but used the wrong errno.
Return the existing ENOENT error from both lookup paths. Extend the NAT reaping test to verify the original destination while tracked and the missing-connection error after reaping. Correct the syscall expectation, close its socket through FileDescriptor, and remove the unrelated raw socket capability requirement from this TCP query.
Assisted-by: OpenAI Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15169 from tamird:original-dst-missing-connection d601665