Repository navigation
Copy netlink memberships in complete words - #15265
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl992760074
branch
9 times, most recently
from
October 7, 2026 20:38
2d6008d to
11680b3
Compare
copybara-service
Bot
requested review from
EtiennePerot and
fvoznika
as code owners
October 7, 2026 20:38
The short-buffer handling introduced in 8d6b0cf copied partial membership words. Linux copies only complete 32-bit words and reports the full bitmap size [1]. Keep that copy boundary in the netlink socket. Check every short buffer length and its untouched tail, and let the multicast test accept the kernel's bitmap size instead of requiring eight bytes. [1]: https://github.com/torvalds/linux/blob/830b3c68c/net/netlink/af_netlink.c#L1766-L1786 Assisted-by: OpenAI Codex <!-- codex-thread: 01a0680f-bbf5-7511-95f7-4414f4e10d2e --> FUTURE_COPYBARA_INTEGRATE_REVIEW=#15161 from tamird:netlink-membership-copy 6e908d7 PiperOrigin-RevId: 992760074
copybara-service
Bot
force-pushed
the
test/cl992760074
branch
from
October 7, 2026 22:31
11680b3 to
3c5df59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy netlink memberships in complete words
The short-buffer handling introduced in 8d6b0cf copied partial membership words. Linux copies only complete 32-bit words and reports the full bitmap size 1.
Keep that copy boundary in the netlink socket. Check every short buffer length and its untouched tail, and let the multicast test accept the kernel's bitmap size instead of requiring eight bytes.
Assisted-by: OpenAI Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15161 from tamird:netlink-membership-copy 6e908d7