Repository navigation
Remove duplicate network checkpoint variants - #15257
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl992739935
branch
6 times, most recently
from
October 6, 2026 00:21
df1c11f to
ca03123
Compare
f4da28b made save-restore-netstack a no-op because checkpoints always include network state. The syscall test generator still emitted a second set of save/restore targets that differed only by this ignored flag. Make also continued to pass TEST_SAVE_RESTORE_NETSTACK after that change removed its reader. Remove the duplicate targets, their internal runner option, and the unused Make setting. The ordinary save/restore variants continue to exercise network checkpoints; save/resume remains a separate mode. Assisted-by: OpenAI Codex <!-- codex-thread: 01a0680f-bbf5-7511-95f7-4414f4e10d2e --> FUTURE_COPYBARA_INTEGRATE_REVIEW=#15188 from tamird:syscall-save-restore-variants 2a8efe7 PiperOrigin-RevId: 992739935
copybara-service
Bot
force-pushed
the
test/cl992739935
branch
from
October 6, 2026 02:02
ca03123 to
131edbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate network checkpoint variants
f4da28b made save-restore-netstack a no-op because checkpoints always include network state. The syscall test generator still emitted a second set of save/restore targets that differed only by this ignored flag. Make also continued to pass TEST_SAVE_RESTORE_NETSTACK after that change removed its reader.
Remove the duplicate targets, their internal runner option, and the unused Make setting. The ordinary save/restore variants continue to exercise network checkpoints; save/resume remains a separate mode.
Assisted-by: OpenAI Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15188 from tamird:syscall-save-restore-variants 2a8efe7