Repository navigation
proc: return ESRCH for /proc/<pid>/stat of a reaped task - #15247
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl992613446
branch
3 times, most recently
from
October 6, 2026 00:20
c4e1a88 to
8ad8f09
Compare
## Summary If `IDOfTask` is 0 while generating `/proc/<pid>/stat`, return ESRCH instead of printing pid 0. Holding the file open across `waitpid` races `Generate()` with `deleteTask`: after Zombie→Dead, `IDOfTask` returns 0 and stock gVisor emitted `0 (comm) ...`. Linux returns ESRCH once the task is gone. ## Linux Fidelity `proc_tgid_stat` / `do_task_stat` fail with `-ESRCH` when the task cannot be found. Printing tgid 0 is not a Linux result. ## Test Plan - `ProcPidStatTest.ReapedTaskNeverReportsPIDZero` holds `/proc/<pid>/stat` open across reap. - Stock gVisor: reads start with `"0 "`; failed 3/3. - Patched gVisor: passed 3/3 (ESRCH/ENOENT or a real pid). Made with [Cursor](https://cursor.com) FUTURE_COPYBARA_INTEGRATE_REVIEW=#15012 from hugelgupf:pr/procstat-reaped-esrch b0db366 PiperOrigin-RevId: 992613446
copybara-service
Bot
force-pushed
the
test/cl992613446
branch
from
October 6, 2026 02:08
8ad8f09 to
5604f85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proc: return ESRCH for /proc//stat of a reaped task
Summary
If
IDOfTaskis 0 while generating/proc/<pid>/stat, return ESRCH instead of printing pid 0.Holding the file open across
waitpidracesGenerate()withdeleteTask: after Zombie→Dead,IDOfTaskreturns 0 and stock gVisor emitted0 (comm) .... Linux returns ESRCH once the task is gone.Linux Fidelity
proc_tgid_stat/do_task_statfail with-ESRCHwhen the task cannot be found. Printing tgid 0 is not a Linux result.Test Plan
ProcPidStatTest.ReapedTaskNeverReportsPIDZeroholds/proc/<pid>/statopen across reap."0 "; failed 3/3.Made with Cursor
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15012 from hugelgupf:pr/procstat-reaped-esrch b0db366