Keep IPv6 subnet setup valid through its assertion - #15196
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl991804473
branch
from
October 1, 2026 20:32
85ad222 to
db5e793
Compare
JoinSubnet, added in 339d266, leaves its address on the loopback interface, so its second socket parameter fails setup with EEXIST. A checkpoint after adding the address also replaces network configuration: the bind assertion can then pass without its prerequisite subnet, and checked cleanup finds that the address is already gone. Require successful setup and remove the address on scope exit. Keep this temporary network configuration outside cooperative checkpoints, then checkpoint the still-open socket after cleanup. Both socket parameters retain the original bind assertion and report setup or cleanup failures. Assisted-by: Codex <!-- codex-thread: 01a0680f-bbf5-7511-95f7-4414f4e10d2e --> FUTURE_COPYBARA_INTEGRATE_REVIEW=#15124 from tamird:netlink-test-address-cleanup a2d673b PiperOrigin-RevId: 991804473
copybara-service
Bot
force-pushed
the
test/cl991804473
branch
from
October 1, 2026 21:13
db5e793 to
6a9364b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep IPv6 subnet setup valid through its assertion
JoinSubnet, added in 339d266, leaves its address on the loopback interface, so its second socket parameter fails setup with EEXIST. A checkpoint after adding the address also replaces network configuration: the bind assertion can then pass without its prerequisite subnet, and checked cleanup finds that the address is already gone.
Require successful setup and remove the address on scope exit. Keep this temporary network configuration outside cooperative checkpoints, then checkpoint the still-open socket after cleanup. Both socket parameters retain the original bind assertion and report setup or cleanup failures.
Assisted-by: Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15124 from tamird:netlink-test-address-cleanup a2d673b