Conversation
tamird
force-pushed
the
checkescape-generics
branch
2 times, most recently
from
September 26, 2026 20:37
2009301 to
dcd7c3d
Compare
tamird
changed the title
tamird
force-pushed
the
checkescape-generics
branch
4 times, most recently
from
September 27, 2026 12:36
27c9497 to
47f9bf0
Compare
zkoopmans
approved these changes
Sep 29, 2026
zkoopmans
left a comment
zkoopmans
left a comment
Contributor
There was a problem hiding this comment.
Minor nit, but otherwise approved. Thanks for the patch!
tamird
force-pushed
the
checkescape-generics
branch
3 times, most recently
from
September 30, 2026 03:50
bcfd027 to
44627fd
Compare
zkoopmans
approved these changes
Sep 30, 2026
checkescape cannot reliably check generic functions or their callers, preventing nosplit helpers from being factored into generic packages. Its concrete analysis also misses implicit calls introduced by the Go compiler. Analyze generic and concrete functions through one type-aware model of source operations and their possible runtime effects. Use compiled code to rule out eliminated effects in concrete functions; check generic declarations against every permitted type argument and share their facts with callers. Matching compiler calls to the operations that caused them both finds previously missed escapes and avoids attributing unrelated calls to allocations. Use the existing local exemption for metric field lookup's known stack splitting risk. This lets the analyzer land before a nosplit replacement (google#14879), while keeping the remaining metric operations checked. Assisted-by: Codex
tamird
force-pushed
the
checkescape-generics
branch
from
October 1, 2026 02:51
44627fd to
43e2272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkescape cannot reliably check generic functions or their callers, preventing nosplit helpers from being factored into generic packages. Its concrete analysis also misses implicit calls introduced by the Go compiler.
Analyze generic and concrete functions through one type-aware model of source operations and their possible runtime effects. Use compiled code to rule out eliminated effects in concrete functions; check generic declarations against every permitted type argument and share their facts with callers. Matching compiler calls to the operations that caused them both finds previously missed escapes and avoids attributing unrelated calls to allocations.
Use the existing local exemption for metric field lookup's known stack splitting risk. This lets the analyzer land before a nosplit replacement (#14879), while keeping the remaining metric operations checked.
Landing still requires #15050 to remove interface boxing from the signal-frame nosplit path.
Assisted-by: Codex