Repository navigation
Do not implicitly allow OPTIONS in CORS config - #46
Open
AshSgDe29071999 wants to merge 1 commit into
Open
AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
isMethodAllowed treated OPTIONS as always allowed, so a preflight with Access-Control-Request-Method: OPTIONS succeeded even when OPTIONS was not in AllowedMethods. Actual OPTIONS requests are uncommon; only list OPTIONS when the server intends to allow them. See go-chi#37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37
isMethodAllowedtreated OPTIONS as always allowed so a preflight withAccess-Control-Request-Method: OPTIONSsucceeded even when OPTIONS was not inAllowedMethods. That lets browsers follow up with an actual OPTIONS request the server did not opt into.Preflight still works: the HTTP method of the preflight is OPTIONS regardless, and
Access-Control-Allow-Methodsnow reflects only configured methods. List OPTIONS explicitly when the server wants to allow non-preflight OPTIONS.