Repository navigation
fix(migration): bound memory when migrating form answers to items_ids - #26249
Merged
Merged
Conversation
The 11.0 -> 12.0 migration fetched glpi_forms_answerssets rows in batches of 250 including their `answers` payload. A single payload can weigh several megabytes (inlined uploads), so one batch exhausted the default 128M memory_limit on real databases. Fetch only ids in batches, then load and migrate each payload on its own, so the peak memory depends on the largest row rather than on the batch.
Code Review by QodoResolved findings 1.
|
trasher
approved these changes
Nov 6, 2026
trasher
left a comment
trasher
left a comment
Contributor
There was a problem hiding this comment.
You could maybe add a test with more than 250 entries to check the "pagination" works? Not a blocker.
Member
Author
|
Added |
ccailly
approved these changes
Nov 6, 2026
trasher
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 11.0 → 12.0 migration loaded
glpi_forms_answerssetsin batches of 250 rows includinganswers; with multi-MB payloads this exhausts the default 128Mmemory_limiton real databases.Ids are now fetched in batches and each payload is loaded on its own, so peak memory depends on the largest row (126 MB → 80 MB on a support DB copy, ~4% slower).
Covered by the existing
QuestionTypeItemItemsIdsMigrationTest.