Repository navigation
Conversation
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewPowered by Qodo |
Rom1-B
requested changes
Nov 5, 2026
Comment on lines
+1087
to
+1089
| if (!Session::haveRight(KnowbaseItem::$rightname, KnowbaseItem::KNOWBASEADMIN)) { | ||
| $criteria[] = KnowbaseItem::getVisibilityDateCriteria(); | ||
| } |
Contributor
There was a problem hiding this comment.
10.0 still listed these in the "Manage" tab for their author, and that tab is gone in 11.0, so a non-admin writer can no longer find their own expired article to extend it.
Authors must continue to be able to view their own articles
| * | ||
| * @return array<int, array<string, mixed>> WHERE clause | ||
| */ | ||
| public static function getVisibilityDateCriteria(): array |
Contributor
There was a problem hiding this comment.
The search case and showRecentPopular() still build the same criteria inline, they can use the new helper too: lines with comment "// Add visibility date"
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the knowledge base browse tab was moved to the standard search engine, articles outside of their visibility period are listed to every user allowed to see them. An article whose "Visible until" date is in the past, or whose "Visible since" date is in the future, still shows up in the browse tab of the knowledge base and of the helpdesk FAQ for users without the knowledge base administration right. In 10.0 these articles were hidden from that list, and they are still hidden from the text search and from the recent and popular lists.
The default search criteria for knowledge base items now apply the begin and end date restriction for users without the knowledge base administration right. This is the same rule the former browse list used. The date criteria were moved to a reusable method, and a test checks the search results for a technician, a self-service user and a super-admin.