Skip to content

[Fix]: Custom images from Helpdesk home scenes mispositioned - #26195

Open
jdurand-teclib wants to merge 2 commits into
glpi-project:11.0/bugfixesfrom
jdurand-teclib:fix/47328/helpdesk-index-scene-align-issue
Open

jdurand-teclib wants to merge 2 commits into
glpi-project:11.0/bugfixesfrom
jdurand-teclib:fix/47328/helpdesk-index-scene-align-issue

Conversation

@jdurand-teclib

Copy link
Copy Markdown
Contributor
  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !47328
  • Here is a brief description of what this PR does
    • Fix an issue where custom images were not correctly positioned in helpdesk's simplified view index (aligned in the center of the scene instead of the bottom
    • Added e2e tests to cover the fix and ensure a custom image will stick to the bottom of a scene

Screenshots (if appropriate):

Before:
image

After:
image

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Code Review by Qodo


View medium (1)
🟠 **Medium**
1. Custom images remain centered vertically 🐞 Bug
Description
The new .scene img rules bottom-align the full-height image element, while object-fit: contain
continues centering the visible pixels inside that element. Wide custom scenes therefore remain
vertically centered and fail the added assertion that their rendered content touches the scene
bottom.
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The custom scene image element is rendered at 100% width and height, so `bottom: 0` moves only its full-size box. With `object-fit: contain`, a wide image retains centered object positioning and its visible pixels do not reach the scene bottom.
### Fix Focus Areas
- css/helpdesk_home.scss[140-145]
- templates/components/illustration/custom_icon.html.twig[33-39]
### Recommended Fix
Set the custom scene image’s `object-position` to `center bottom` (or otherwise constrain the image element to its rendered content) so `object-fit: contain` places the visible image at the bottom of the scene. Preserve the existing containment and responsive behavior, then run the new end-to-end assertion for a wide custom image.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Comment thread css/helpdesk_home.scss Resolved
@jdurand-teclib
jdurand-teclib force-pushed the fix/47328/helpdesk-index-scene-align-issue branch from f885145 to a850ba6 Compare November 2, 2026 14:04
@jdurand-teclib jdurand-teclib self-assigned this Nov 2, 2026
@jdurand-teclib
jdurand-teclib force-pushed the fix/47328/helpdesk-index-scene-align-issue branch from a850ba6 to ba51cf7 Compare November 2, 2026 14:46
Comment thread tests/e2e/specs/Helpdesk/home.spec.ts Resolved
Comment thread tests/e2e/specs/Helpdesk/home.spec.ts Resolved
Comment thread css/helpdesk_home.scss Resolved
@jdurand-teclib
jdurand-teclib force-pushed the fix/47328/helpdesk-index-scene-align-issue branch from 9ac94bf to dc27745 Compare November 4, 2026 08:49
@jdurand-teclib
jdurand-teclib force-pushed the fix/47328/helpdesk-index-scene-align-issue branch from dc27745 to 41621da Compare November 6, 2026 09:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants