Repository navigation
Embed the bootstrap registration template safely - #64974
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix security findings in github/gh-aw
Embed the bootstrap registration template safely
Oct 2, 2026
pelikhan
marked this pull request as ready for review
October 2, 2026 13:18
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The embedded template preserves contextual escaping, regression coverage matches runtime output, and refreshed dependency pins are valid.
Review effort: Balanced
Findings: None
What changed in this PR
Moves the GitHub App registration HTML into a statically embedded template, preventing request-derived values from becoming template source.
Changes:
- Parses the embedded HTML with
html/template. - Adds regression coverage for untrusted URL and manifest values.
- Refreshes generated workflow and action lock data.
| File | Description |
|---|---|
pkg/cli/bootstrap_registration_page.html |
Adds the static registration template. |
pkg/cli/bootstrap_profile_helpers.go |
Embeds and parses the template safely. |
pkg/cli/bootstrap_profile_helpers_test.go |
Tests contextual escaping. |
.github/workflows/visual-regression-checker.lock.yml |
Refreshes generated firewall configuration. |
.github/workflows/spec-enforcer.lock.yml |
Updates the coverage action pin. |
.github/workflows/purelock.lock.yml |
Updates the coverage action pin. |
.github/aw/actions-lock.json |
Synchronizes action pins with workflow sources. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security report flagged command-injection paths in issue-closing handlers and possible template injection in the GitHub App registration page.
exec/asShellArgpaths are absent from this checkout; the current handler uses GitHub API calls without shell execution.