Skip to content

Fix upload-assets job summary formatting - #64089

Merged
pelikhan merged 1 commit into
mainfrom
copilot/fix-upload-artifact-job-summary
Sep 28, 2026
Merged

pelikhan merged 1 commit into
mainfrom
copilot/fix-upload-artifact-job-summary

Conversation

Copilot AI commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

The upload-assets job summary runs its heading, status, and asset links together. The asset list should use the usual collapsed-details format.

  • Summary format: Show publication status first, then place asset links in a collapsed <details> section with proper Markdown spacing.
  • Staged mode: Use the same layout while making clear that assets were not pushed.
  • Coverage: Add assertions for published and staged summaries.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Fix upload assets job step summary formatting Fix upload-assets job summary formatting Sep 28, 2026
Copilot AI requested a review from pelikhan September 28, 2026 22:11
@pelikhan
pelikhan marked this pull request as ready for review September 28, 2026 23:13
Copilot AI balanced review requested due to automatic review settings September 28, 2026 23:13
@pelikhan
pelikhan merged commit 64c4e45 into main Sep 28, 2026
2 checks passed
@pelikhan
pelikhan deleted the copilot/fix-upload-artifact-job-summary branch September 28, 2026 23:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused formatting change is correct and covered by relevant tests.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes upload-assets summaries by separating status text from asset links and using collapsed details.

Changes:

  • Formats published and staged summaries consistently.
  • Adds coverage for both summary modes.
File Description
actions/​setup/​js/​upload_assets.cjs Builds properly spaced, collapsible asset summaries.
actions/​setup/​js/​upload_assets.test.cjs Verifies published and staged summary formatting.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.90.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants