Skip to content

[instructions] Instructions Janitor: sync network.md with release v0.89.21 hosted-web policy - #63399

Merged
pelikhan merged 2 commits into
mainfrom
instructions-janitor-sync-hosted-web-da3391619ee42853
Sep 25, 2026
Merged

pelikhan merged 2 commits into
mainfrom
instructions-janitor-sync-hosted-web-da3391619ee42853

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

Latest release: v0.89.21 (2026-09-23). The prior sync PR (#63142, merged 2026-09-24 09:49 UTC) already brought instructions current with that release. This pass covers what changed in .github/aw/ since that sync.

Release/change audit

  • Commits touching .github/aw/ since the last sync: e6374a3f and c9b6fbf9 only bump .github/aw/actions-lock.json (a generated data file, no prose change needed).
  • 158f1a3 (current HEAD, PR Add hosted web domain policies to workflow frontmatter #63212 "Add hosted web domain policies to workflow frontmatter") added the new network.hosted-web frontmatter field but only documented the import-merge precedence rule (one line in syntax-tools-imports.md). The field itself — syntax, semantics, deny-by-default behavior — was undocumented in .github/aw/network.md, the dedicated network reference file.

Fix

  • Added a "Hosted Web Policy (network.hosted-web)" section to .github/aw/network.md covering: the object/false shape, allowed/blocked mutual exclusivity, max-uses, deny-by-default when network restricts domains for Claude/Codex without an explicit policy, Claude/Codex-only scope, and a cross-link to the import-merge note in syntax-tools-imports.md.

Size audit

  • All .github/aw/*.md files remain under their target limits. network.md: 185 → 205 lines (well under 400).

Duplication audit

  • Spot-checked "single-job" / safe-outputs-routing language across workflow-constraints.md, workflow-patterns.md, create-agentic-workflow.md, github-agentic-workflows.md — these already cross-reference workflow-constraints.md rather than duplicating it. No changes needed.

Accuracy audit

  • Not run in full (schema/compiler source review) — the only concrete gap found in this pass was the hosted-web field, which is now documented. No other drift was identified while investigating that change.

Test plan

  • Verified network.hosted-web schema shape against pkg/parser/schemas/main_workflow_schema.json (lines ~3599-3646) and docs/adr/63212-add-hosted-web-domain-policies.md.
  • wc -l .github/aw/*.md — all files under limits.

🤖 Generated with [Claude Code]((claude.com/redacted)

Generated by 🧹 Instructions Janitor · claude · sonnet50 · 170 AIC · ⌖ 33.1 AIC · ⊞ 7.4K · ◷

  • expires on Sep 27, 2026, 12:47 AM UTC-08:00

The Sep-24 sync (#63142) covered release v0.89.21, but PR #63212
(merged after that sync) added the network.hosted-web frontmatter
field for Claude/Codex provider-hosted web tools without documenting
it in .github/aw/network.md — only a one-line import-merge note was
added to syntax-tools-imports.md.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot This PR looks ready for another pass.

  • Please refresh the branch if needed and then run the pr-finisher skill after reviewing the current head and any pending maintainer follow-ups.
  • This PR has not received a sous-chef nudge yet, so please summarize the current status on the branch for maintainers once done.

Generated by 👨🍳 PR Sous Chef
Comment /souschef to run again

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 51.7 AIC · ⌖ 8.96 AIC · ⊞ 9.6K · ◷
Comment /souschef to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 Great work! This PR from the Instructions Janitor workflow looks ready for merge. The change adds much-needed documentation for the network.hosted-web frontmatter field introduced in PR #63212, ensuring users understand the syntax, semantics, and deny-by-default behavior.

What's included:

  • Comprehensive "Hosted Web Policy" section added to .github/aw/network.md
  • Covers object/false shape, allowed/blocked mutual exclusivity, max-uses, and scope (Claude/Codex only)
  • Cross-references existing import-merge documentation
  • Line count audit confirms all .github/aw/*.md files remain under target limits (network.md: 185 → 205 lines)

Quality signals:

  • ✅ Focused single-purpose change (sync instructions with release v0.89.21)
  • ✅ Well-documented PR with detailed release/change audit
  • ✅ Verification steps included (schema validation, file-size audit)
  • ✅ No new dependencies added
  • ✅ Generated by a trusted team automation workflow

This PR aligns perfectly with the project's goal of keeping instructions current with each release. Ready to go!

Generated by ✅ Contribution Check · copilot · auto · 51.8 AIC · ⌖ 10.5 AIC · ⊞ 9.2K · ◷

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@copilot This PR looks ready for another pass.

  • Please refresh the branch if needed and then run the pr-finisher skill after reviewing the current head and any pending maintainer follow-ups....

Ran the pr-finisher pass. Status:

  • ✅ Reviews — no review threads on this PR; the only comment is this nudge. Code review pass came back clean.
  • ✅ Checks (local) — make agent-report-progress-no-test and make test-unit pass (docs-only change, no Go files touched, no workflow markdown modified).
  • ❓ Checks (CI) — the agent's push does not trigger workflows, so CI on the new HEAD is unverified. No prior CI failures existed to fix.
  • ✅ Mergeable — branch head is up to date with main (158f1a3), no conflicts, not draft.

Actions taken: verified the new network.hosted-web section against the schema, compiler and tests, and corrected three inaccuracies in it — non-Claude/Codex engines raise a compile error rather than ignoring the field, deny-by-default triggers on any explicit network config (not only domain-restricting ones), and import merge combines lists only when both policies are enabled with the main workflow's scalar settings winning.

Hand-off: a maintainer needs to re-trigger CI (close/reopen or push) before merge; the change is docs-only otherwise.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please review the current PR state, address any unresolved feedback or failing checks, refresh the branch if needed, and continue with the pr-finisher skill.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 24.8 AIC · ⌖ 8.56 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again

Copilot AI commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@copilot Please review the current PR state, address any unresolved feedback or failing checks, refresh the branch if needed, and continue with the pr-finisher skill.

Generated by [👨‍🍳 PR...

Second pr-finisher pass complete — no changes were needed, so nothing new was pushed. Head is still c3bec36.

  • ✅ Reviews — zero review threads and zero submitted reviews on this PR. The only unresolved item is the pending review request on @gh-aw-bot, which requires a human.
  • ✅ Checks (local) — re-ran make agent-report-progress-no-test and make test-unit on c3bec36; both pass. No Go files, schemas, or workflow markdown are touched, so the recompile/schema-freshness steps correctly no-op.
  • ❓ Checks (CI) — nothing failed. The three pull_request workflows (AI Moderator, Content Moderation, Agentic Commands) are sitting at action_required, i.e. awaiting maintainer approval for a bot-authored PR — not a failure I can fix or re-trigger. No lint/test CI workflow has run on either head.
  • ✅ Mergeable — origin/main is still 158f1a3 and is an ancestor of HEAD, so the branch is not behind; no conflicts, not draft. mergeable_state: blocked reflects the missing approval/required checks, not a branch problem.

Diff remains a single docs file: .github/aw/network.md, +21 lines.

Hand-off: a maintainer needs to approve the pending workflow runs and review the PR. Nothing further is actionable from my side.

@pelikhan
pelikhan merged commit ae2331a into main Sep 25, 2026
1 check passed
@pelikhan
pelikhan deleted the instructions-janitor-sync-hosted-web-da3391619ee42853 branch September 25, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation documentation Improvements or additions to documentation instructions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants