Remove the Workspace activity badge in Lite - #15757
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
The new E2E assertion for the Upstream tab count is overly brittle (exact text concatenation) and should be relaxed to avoid false failures from harmless markup/whitespace changes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR removes the ambiguous “Workspace” activity numeric badge from the Lite workspace sidebar, along with its related unread-count hook and query subscriptions, and adds an E2E regression test to ensure unread PR activity is still surfaced via the intended indicators (bell/branch marker) while the Workspace tab remains unbadged.
Changes:
- Removed the Workspace activity badge UI and its supporting forge/review query subscriptions in the Lite workspace sidebar.
- Deleted the unused
useUnreadReviewCounthook from the review-seen module. - Added a Lite E2E sidebar regression test covering unread PR activity indicators and the absence of the Workspace badge.
File summaries
| File | Description |
|---|---|
| apps/lite/ui/src/routes/project/$id/workspace/Sidebar.tsx | Removes rendering of the Workspace activity badge and related imports. |
| apps/lite/ui/src/review-seen.ts | Removes the now-unused unread review counting hook export. |
| apps/lite/e2e/tests/sidebar.spec.ts | Adds an E2E test asserting unread PR activity does not appear as a Workspace tab badge while other indicators remain. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1a2d0f6 to
0d07f88
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The badge removal is complete (including unused hook cleanup) and the added E2E test covers the intended regression surface without introducing apparent risk.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
Context
While checking unread pull request activity on an applied branch, an unexplained numeric badge beside Workspace made its meaning ambiguous. It looked like Upstream's incoming-commit count, but counted unread PRs. The notification bell and branch/PR indicators remain, and Upstream continues to show incoming commits.
Related history: #15736
Change
Remove the Workspace badge and its unused subscriptions and count hook. Add a rendered sidebar regression test for unread PR activity and the preserved indicators.
FYI @PavelLaptev