Qodana: cold-cache diagnostic run without the XmlHighlighting exclusion - #309
Open
ghostflyby wants to merge 4 commits into
Open
ghostflyby wants to merge 4 commits into
ghostflyby wants to merge 4 commits into
Conversation
…lusion JetBrains support asked for a rerun with a cold Qodana cache to check whether the GradleTypesafeConventions XmlHighlighting problems survive it (PR runs were falling back to the cache built on main): - drop the XmlHighlighting exclude from qodana.yml - remove the Qodana native cache restore/save steps - pass --clear-cache --log-level debug and upload the report artifact
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Qodana for JVM22 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
…alysis Run 35611900107 turned out to be inconclusive: qodana-action defaulted to pr-mode, so the analysis ran with --script scoped:<diff-scope> over only the two changed YAML files, and every result in its SARIF was merged from the baseline (all `unchanged`, report UI empty). Neither the 0 XmlHighlighting count nor the "healthy" verdict says anything about a cold full analysis. - disable pr-mode so the whole project is analysed - drop --baseline so every problem is exposed instead of being labelled unchanged against main's accepted set
The scope#$spi ignore was added because batch analysis cannot resolve the tooling-API service provider/interface references (annotator-level false positives). Remove it on this diagnostic branch to check whether those problems (a) reproduce outside pr-mode at all and (b) land in qodana.sanity.results like they used to.
…ppression `<!--suppress XmlHighlighting -->` has sat in front of supportsKotlinPluginMode since the plugin was created, and whether it silences anything in qodana batch analysis was never verified (annotator-class problems were assumed immune to suppress comments). Remove it so the cold full runs measure the bare descriptor; the qodana-level XmlHighlighting exclusion is already lifted on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic PR requested by JetBrains support: rerun the analysis with a cold Qodana cache and share the logs/report.
Changes against main:
qodana.yml: removed theXmlHighlightingexclude for the two GradleTypesafeConventions descriptor files..github/workflows/inspect-code.yml:Restore Qodana Cachestep (and itsCompute Qodana Cache Layout,Compute Qodana Cache KeyandSave Qodana Cachecompanions), so the analysis no longer reuses the cache built onmain;--clear-cache --log-level debugandupload-result: true, so the full report is uploaded as theqodana-reportartifact.This branch is diagnostic only and will be reverted once we know whether the XmlHighlighting problems survive the cold-cache run.