Add support for skipping Azure KeyVault Uri Verification#1981
Open
PleaseStopAsking wants to merge 2 commits into
Open
Add support for skipping Azure KeyVault Uri Verification#1981PleaseStopAsking wants to merge 2 commits into
PleaseStopAsking wants to merge 2 commits into
Conversation
Signed-off-by: Michael Hatcher <mhatcher@esri.com>
Author
|
@felixfontein Is there anything I can do to get this moved along as its a major roadblock for me at the moment. Thanks! |
Author
|
bump for review or clarification if this is not going to be considered. |
Author
|
@hiddeco @felixfontein Would love any sort of feedback on this functionality making it into a release because as it stands, azure key vaults behind a CNAME based proxy are completely unusable. |
Contributor
|
I have zero experience with AZKV and can't say much about this, but the way this PR implements a solution looks very wrong to me. If instead passing things through the keyservice it would use environment variables as the other cloud-based keyservices I think it would be a lot cleaner. Others from @getsops/maintainers might be able to give better comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (attempt 2) introduces support for skipping the Azure Key Vault Uri Verification that was introduced in azure-sdk-for-go/sdk/security/keyvault/azkeys@v1.0.0 which sops integrated with v3.8.0. This change introduced issues for those who use Key Vaults that are located behind proxies that leverage CNAMES.
Original MS Blog: https://devblogs.microsoft.com/azure-sdk/guidance-for-applications-using-the-key-vault-libraries/
Previous PR: #1980