fix(ci): Update tests to seed the correct column for ai_conversations - #120608
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e7ce3a1. Configure here.
| organization_id=span["organization_id"], | ||
| project_id=span["project_id"], | ||
| item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN, | ||
| conversation_id=span.get("ai_conversation_id", ""), |
Contributor
There was a problem hiding this comment.
Test helper mismatches production path
Medium Severity
span_to_trace_item seeds TraceItem.conversation_id from a fabricated ai_conversation_id field and asserts when only gen_ai.conversation.id is present. Production convert_span_to_item still derives the column from that attribute and keeps it, so this rejects valid production-shaped test data and mislabels the attribute as deprecated.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e7ce3a1. Configure here.
phacops
reviewed
Jul 24, 2026
pbhandari
force-pushed
the
fix/seed-correct-ai_conversation_id-field
branch
from
July 25, 2026 00:00
e7ce3a1 to
2beeffb
Compare
pbhandari
commented
Jul 25, 2026
vgrozdanic
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Tests were only seeding the un-indexed
gen_ai.conversation.idfield when running the tests. After merging snuba side perf-improvements in getsentry/snuba#8185; the CI started failing due to us not seeding the right field.This now updates the tests so that we always seed the indexed column; and adds a useful error message if we end up forgetting this.
Original failing CI run: https://sentry.slack.com/archives/CUHS29QJ0/p1784920298033589
Snuba CI has been updated to use the failing test in getsentry/snuba#8221, updating the CI to use this branch temporarily causes the CI to pass in this run.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.