Skip to content

test(mcp): Remove unused select_mcp_transactions fixture - #8150

Merged
sentrivana merged 1 commit into
masterfrom
ivana/remove-select-mcp-transactions
Oct 29, 2026
Merged

sentrivana merged 1 commit into
masterfrom
ivana/remove-select-mcp-transactions

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes the select_mcp_transactions fixture from tests/conftest.py. Nothing has used it since #5292.

#5383 added it as a helper in the MCP tests, and #5384 turned it into a shared conftest.py fixture for the MCP and FastMCP Streamable HTTP tests. A few days later, #5292 ("Nest MCP spans under HTTP transactions") switched those tests to select_transactions_with_mcp_spans and removed every use of select_mcp_transactions, but left the definition behind.

Evidence

  • git grep select_mcp_transactions matches only the definition. No test requests it as an argument, and no request.getfixturevalue(...) call uses that name.
  • No open PR or issue mentions it.

This only touches test code, so SDK behavior doesn't change.

Issues

n/a

via Ivana Kellyer.

--

View Junior Session [Sentry]

Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner October 29, 2026 10:45
@sentrivana
sentrivana enabled auto-merge (squash) October 29, 2026 10:45
@sentrivana
sentrivana merged commit cc257a4 into master Oct 29, 2026
170 checks passed
@sentrivana
sentrivana deleted the ivana/remove-select-mcp-transactions branch October 29, 2026 10:55
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 442m 19s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.33% (up 0.03 percentage points from base (825ff97) to head (91a3f6f)).

Coverage diff
@@            Coverage Diff             @@
##        master     #8150       +/-##
==========================================
+ Coverage    90.30%    90.33%    +0.03%
==========================================
  Files          203       203         —
  Tracked lines     26873     26873         —
  Branches     10044     10044         —
==========================================
+ Hits         24266     24275        +9
+ Misses        2607      2598        -9
+ Partials      1520      1518        -2

Generated by Coverage Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant