[Do Not Review] ci: Add Android 17 (API 37) to critical UI test emulator matrix#5673
Draft
0xadam-brown wants to merge 6 commits into
Draft
[Do Not Review] ci: Add Android 17 (API 37) to critical UI test emulator matrix#56730xadam-brown wants to merge 6 commits into
0xadam-brown wants to merge 6 commits into
Conversation
Add API level 37 using the Google APIs x86_64 canary channel image so critical Maestro UI tests run on the new platform before compileSdk bump. Co-authored-by: Cursor <cursoragent@cursor.com>
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 304.04 ms | 370.33 ms | 66.29 ms |
| 4e3e79d | 365.83 ms | 477.62 ms | 111.79 ms |
| d8912da | 329.94 ms | 389.68 ms | 59.74 ms |
| d15471f | 294.13 ms | 399.49 ms | 105.36 ms |
| abf451a | 332.82 ms | 403.67 ms | 70.85 ms |
| 604a261 | 380.65 ms | 451.27 ms | 70.62 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| 22f4345 | 307.87 ms | 354.51 ms | 46.64 ms |
| d217708 | 375.27 ms | 415.68 ms | 40.41 ms |
| c3ee041 | 310.64 ms | 361.90 ms | 51.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 4e3e79d | 0 B | 0 B | 0 B |
| d8912da | 0 B | 0 B | 0 B |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| abf451a | 1.58 MiB | 2.20 MiB | 635.29 KiB |
| 604a261 | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| c3ee041 | 0 B | 0 B | 0 B |
GitHub Actions sdkmanager publishes platforms;android-37.0 rather than android-37, which caused the emulator runner to fail package install. Co-authored-by: Cursor <cursoragent@cursor.com>
YAML parses bare 37.0 as the float 37, so the emulator runner still requested platforms;android-37. Quote the value so sdkmanager installs platforms;android-37.0 on GHA runners. Co-authored-by: Cursor <cursoragent@cursor.com>
GHA publishes platforms;android-37.0 but system-images;android-37 for the emulator image. Pass system-image-api-level separately from api-level. Co-authored-by: Cursor <cursoragent@cursor.com>
Probe sdkmanager for system-images;android-37 before starting the emulator. Platform 37.0 installs successfully, but Google has not yet published the matching Google APIs x86_64 image on GHA runners. Co-authored-by: Cursor <cursoragent@cursor.com>
sdkmanager is not on PATH until android-emulator-runner runs; invoke it via ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager instead. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api-level: 37.0— GHA sdkmanager publishesplatforms;android-37.0, notandroid-37Test plan
#skip-changelog
Made with Cursor