fix(head): drop misleading commit-hash fallback for application version#1987
Merged
Conversation
hugo.CommitHash is the Hugo executable's build commit, not the site's, so it rendered a constant misleading value. Resolve the application version from config or HUGO_APPLICATION_VERSION only; render no tag when neither is set. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
🎉 This PR is included in version 2.18.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a misleading fallback in the application-version resolver added in v2.18.0.
hugo.CommitHashis the Hugo executable's build commit (a constant across every site built with the same Hugo binary), not the site's commit — so a site that opted in via[params.application]without supplying a version rendered a bogus, constant "version" string.The resolver now resolves the version from
params.application.versionor theHUGO_APPLICATION_VERSIONenvironment variable only, and renders no<meta name="application">tag when neither is set.Verification
Built
exampleSite:[params.application]+HUGO_APPLICATION_VERSION=9.9.9→content="… 9.9.9";[params.application]with no version and no env var → no tag (previously leaked the Hugo binary's commit hash); no block → no tag.🤖 Generated with Claude Code