Spaces in image filenames

[nclm]

Users are able to upload page images with a space in their filenames.
However, when inserted, the Markdown is not interpreted and appear instead of the image.

![](My image.jpg)

There is no clear way to make it work besides renaming the image locally and re-uploading it, and no obvious reason it’s not working from the user’s pov.

Ways it could work:

• Renaming images on upload, for instance with a _ instead of the space.
• Support some way to bypass the space such as ![](My%20image.jpg) or ![]('My image.jpg') or ![](<My image.jpg>) and have the inserted Markdown automatically in that format.
• Just support spaces.

[rhukster]

Thanks for the report. The root cause was in Markdown parsing: Parsedown's link/image parser rejects raw spaces in a URL, so ![](My image.jpg) never reached Grav's media handling and fell through as literal text.

Fixed for the next release (2.0.9) by adding support for CommonMark angle-bracket destinations, so you can reference a file with spaces like this:

![](<My image.jpg>)

![](My%20image.jpg) also works (Grav decodes it when resolving the media). A bare, unescaped space is not valid Markdown, so ![](My image.jpg) on its own still won't render, but the angle-bracket form is the standard CommonMark escape and now works everywhere in Grav.

The admin editors were also updated to emit the correct form automatically when you insert a media file whose name contains spaces (Editor Pro 2.0.10, Admin 1.10.53), so in practice you won't need to type the brackets by hand.

[nclm]

Perfect, thank you!

[nclm]

I opened #4251 for non-image files, but actually this seems broken again for images.
Just did a test with a PNG on Grav v2.0.19, and it created the Markdown without angle-brackets, and that doesn’t work.

[nclm]

Or maybe it never worked? In how I saw it, Grav should automatically add the angle-brackets for every media inserted that have a space. Whether you drag and drop it, click the plus, or use the media selector. Otherwise it seems like a bug to users (they insert something but it doesn’t insert or link to it).

[rhukster]

Thanks for coming back with this, and sorry for the confusion. You're right, and the answer to "did it ever work?" is: not in the editor you're using. The July fix landed in Grav core (so the angle-bracket form renders), in Editor Pro, and in the classic 1.x admin, but the new admin's default markdown editor was missed. It has always inserted the bare filename, whether you drag the thumbnail in, click the plus button, or pick from the image dialog, so an image with a space in its name never rendered from that editor. Nothing regressed; it was just never covered there.

The fix is in the admin (the Admin2 plugin), not Grav core, and it will be in the next Admin2 release (2.1.1). After that, every insert path wraps a name containing spaces as <My image.jpg> automatically, so you won't have to type anything by hand. Existing pages with the bare form will still need the brackets added once (or re-insert the image).

[nclm]

Super, thanks so much!

[complanar]

I have just to come back to this, as I believe there is another issue with it – in Grav core, I think.

If you set pages.media_route_urls: true and activate the corresponding rule in .htaccess every file with spaces in it becomes a 404.

Can reproduce with a fresh install of Grav 2.2.1