Repository navigation
Set default table row index - #2908
Conversation
Signed-off-by: sschulz92 <bastie92_spam@gmx.de>
Signed-off-by: sschulz92 <bastie92_spam@gmx.de>
Benchmark Results
Notes
See Workflow log for more details. |
|
@haroon-sheikh @chadlwilson Can one of you request the Copilot review please or have a look onto this changes which are limited to the actual issue I want to solve? :) |
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues, and regression tests cover the changed index handling, though tests were not executed.
No open issues 🎉
What changed in this PR
Makes unused table row indices explicitly -1, distinguishing them from row zero without changing the protobuf schema.
Changes:
- Sets explicit spec and scenario table indices during scenario copying and result creation.
- Preserves
-1indices when merging results and adds regression coverage. - Bumps Gauge to version 1.6.41.
| File | Description |
|---|---|
| version/version.go | Bumps version to 1.6.41. |
| parser/dataTableSpecs.go | Sets indices explicitly when copying scenarios. |
| parser/dataTableSpecs_test.go | Covers table-use combinations and expected indices. |
| execution/result/specResult.go | Sets unused scenario table indices to -1. |
| execution/result/specResult_test.go | Checks serialized table indices. |
| execution/merge.go | Preserves indices for scenarios without a spec table row. |
| execution/merge_test.go | Tests merging mixed table-related scenarios. |
Review effort: Balanced
Signed-off-by: sschulz92 <bastie92_spam@gmx.de>
|
Any chance to have this topic done and dealt with 😬 @chadlwilson if you cannot review it, whom should I ask instead? |
|
@sschulz92 Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
chadlwilson
left a comment
There was a problem hiding this comment.
Let's give it a go, seems pretty straightforward here now (although execution result merging and reruns always do my head in).
As the other PR is messed up with changes suggested by AI, I decided to create a new branch from scratch.
My goal is, to set the tableRowIndex of each scenario to the correct value:
Why is this change necessary at all? If I do not set the tableRowIndex directly, those values are converted to
0using the proto3 syntax. Generated functions are returning "0" as default integer value. To avoid any additional change in gauge-proto, we can simply rely on integer values if they are set.Related PR: #2879