Ship message editing as a standard feature - #3424
Merged
ymichael merged 2 commits intoSep 10, 2026
Merged
Conversation
ymichael
deleted the
bb/ship-editable-messages-experiment-thr_uufbzs8six
branch
September 10, 2026 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Message editing was already enabled by default, but the app and server still gated it behind the
editMessagesexperiment. Users who previously disabled the experiment could not edit otherwise eligible messages.What changed
Promote message editing to a standard feature by removing the experiment key, Settings toggle, and app/server gates. Preserve provider rewind support and existing thread/message eligibility checks. Update fixtures, CLI guide templates, settings documentation, and the affected verification recipes. Existing CLI and SDK editing surfaces now work without the experiment. Bump the plugin SDK to
0.4.54because removing the experiment changes its bundled declarations. No host-daemon wire changes.How you verified
node packages/plugin-sdk/scripts/check-npm-version-guard.mjs— passed after the SDK version bump.pnpm exec turbo run test --filter=@bb/server --filter=@bb/db --filter=@bb/app -- experiments thread-edit-message— 51 tests passed. Message-edit service tests now seed a legacy disabled experiment value to verify it no longer blocks editing.pnpm exec turbo run typecheck --filter=@bb/app --filter=@bb/server --filter=@bb/desktop --filter=@bb/cli— passed.Isolated source app: confirmed Settings → Experiments shows only the four remaining toggles, and
/api/v1/system/configexcludeseditMessages. Stopped the test app and removed its marked test data afterward.git diff --check— passed. Live provider rewind was not rerun; service tests cover the editing flow. The broader verification inventory remains blocked by pre-existing drift for the unmappedbrowserCLI family.