Simplify Account Pooler sign-in dialog - #3423
Merged
ymichael merged 2 commits intoSep 10, 2026
Merged
Conversation
The Account Pooler device sign-in dialog rendered "Sign in to <provider>" twice: once as the dialog title and again as an h3 above the step instructions. The step heading carried no information the dialog title did not already give, and it pushed the device code further down the drawer on mobile. Drop the redundant step heading and keep the step-specific instructions as the dialog body copy, matching the other Account Pooler dialogs, which pair a single DialogTitle with a muted instruction paragraph. The final step keeps its distinct "Connected <account>" heading. Verified with the Codex and Claude flows at 1280x900 and 390x844 against a local fake device-auth fixture: one accessible dialog name, progress indicator, device code, copy/open, expiry countdown, cancel and close all unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The sign-in dialog's footer Cancel duplicated the header close: both ran closeDialog, which cancels the Codex device session and stops polling. The header close only existed on wide viewports, though, because DialogContent renders it for the dialog branch and not for the compact drawer, so simply dropping Cancel would have left touch users with swipe or Escape as the only way to back out of a half-finished sign-in. Render the close control in DialogFrame's own header instead, with hideCloseButton on DialogContent so there is exactly one on both viewports, and drop the redundant footer Cancel. The Codex sign-in step now has no footer actions at all, so DialogFrame skips the footer when there are none. Claude keeps Complete and the final step keeps Add another and Done. Verified in the browser at 1280x900 and 390x844 against a local fake device-auth fixture: the drawer shows a Close button, closing it cancels the pending sign-in and no further device-token polls reach the fixture, and the dialog keeps its accessible name. Tests cover the close path on both compact and wide viewports. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ymichael
deleted the
bb/remove-duplicate-account-pooler-sign-in-heading-thr_492b4qc87c
branch
September 10, 2026 17:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The Account Pooler sign-in flow rendered the provider sign-in label twice: once as the accessible dialog title and again as a visual step heading. The footer Cancel button duplicated the dialog close action, while the compact drawer did not expose the corresponding header close control.
What changed
Sign in to …title and retain the provider-specific instruction copy.DialogClosein the Account Pooler dialog header so both desktop dialogs and compact drawers retain an explicit close action.No host-daemon wire, CLI, guide, or public plugin API contract changes are involved.
How you verified
pnpm exec turbo run test typecheck --filter=bb-plugin-account-pool --force— 269 tests passed; typecheck passed.pnpm exec oxfmt --check plugins/account-pool/app.tsx plugins/account-pool/app.test.tsxgit diff --check