Keep reasoning controls reachable in mobile model picker - #3417
Merged
ymichael merged 1 commit intoSep 10, 2026
Merged
Conversation
The compact model picker let the whole drawer be one scroll container, so a long catalog (Pi ships 437 models) pushed the Reasoning toggles ~15,000px below the fold. Make the model list the only scroller inside the drawer and pin the reasoning, fast-mode and footer rows beneath it, and let the persistent drawer shrink above the software keyboard. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ymichael
force-pushed
the
bb/keep-reasoning-controls-reachable-in-mobile-mode-thr_fui9ef6bbw
branch
from
September 10, 2026 16:21
e2be0c5 to
3008a45
Compare
ymichael
deleted the
bb/keep-reasoning-controls-reachable-in-mobile-mode-thr_fui9ef6bbw
branch
September 10, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The compact model picker let its model list grow without a height allocation while the entire drawer body handled scrolling. With long catalogs such as Pi’s 437 models, the list became roughly 15,800px tall and pushed Reasoning, fast-mode, and footer controls far below the visible drawer. The persistent drawer also did not account for software-keyboard overlap.
What changed
Make the compact picker a shrinkable flex column with the model list as its sole independently scrollable region. Provider controls and the reasoning/footer controls remain outside that scroller, while desktop retains its existing 256px list cap.
Teach the shared persistent drawer to measure Visual Viewport keyboard overlap, lift above it, and reduce its maximum height by the same inset. The existing close/reset path clears the inline keyboard styles, and the app-root/deferred-realization behavior is unchanged.
How you verified
@bb/appsuite passed: 502 files and 4,204 tests@bb/appand@bb/shared-uigit diff --checkpassedNo linked issue.