Guard palette keyboard actions during IME composition - #3414
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Guard palette keyboard actions during IME composition#3414bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
2 tasks
ymichael
pushed a commit
that referenced
this pull request
Sep 10, 2026
## Human comments ## What was wrong The Cmd-K palette consumed Enter and navigation keys during IME composition. Confirming a candidate could activate the highlighted result and close the palette; navigation keys could move the palette selection. ## What changed Return before palette keyboard handling when the native event is composing. Cover Enter, ArrowDown, ArrowUp, Home, and End, preserving selection and leaving composing events unconsumed. Also verify ordinary navigation and exactly-once command activation after composition ends. Combines the useful regression assertions from #3414 without duplicating its identical production fix. No wire, SDK, CLI, configuration, or host-daemon protocol changes. ## How you verified - Independently reproduced on pristine main `7ba69eb050c4a800db9255c8fbaaa23ca4bab32d` in the running app using Chromium DOM CompositionEvent/KeyboardEvent dispatches. - Regression-only run before the guard: 6 failed, 23 passed. - `pnpm exec turbo run test --filter=@bb/app -- src/components/commands src/lib/command-palette`: 76 passed across 7 files. - `pnpm exec turbo run typecheck build lint --filter=@bb/app`: passed; lint reported 190 warnings and zero errors. - Changed-file formatting and `git diff --check`: passed. - Real Chromium browser QA: 10 scenarios passed, including unchanged composing selection, default-prevention semantics, resumed navigation and one sidebar toggle after normal Enter. - Composition events were synthetic (`isTrusted: false`); ordinary keys used trusted browser keyboard input. Native OS Pinyin candidate UI, Safari event ordering, and iOS were not verified. Fixes #3413 > AGENT GENERATED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The palette keydown handler consumed Enter and selected the highlighted result even when the native event was composing. Reproduction report.
What changed
Ignore composing events before palette keyboard handling. Add a regression that checks the event remains unconsumed, the palette stays open, no command runs, and a subsequent normal Enter activates the command. Two files in the command subsystem; 28 added lines, 0 deleted lines (28 total).
How you verified
8ac123f3551e7502a91c93e87329797f34ee626b:defaultPreventedwas true, expected false.pnpm exec turbo run test --filter=@bb/app -- src/components/commands: 55 tests passed across 4 files, including the new regression.pnpm exec turbo run typecheck --filter=@bb/app: passed. Full Turbo build: passed.git diff --check: passed; no binary changes. Working tree, HEAD, report artifacts, and push range passed the EAP codename scan using an equivalent Python check because the installed Bash cannot run the scanner.Fixes #3413