Skip to content

Fix compact hover using shared overlay policy #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ymichael merged 7 commits into from
Sep 11, 2026
+21 −9
Merged

Fix compact hover using shared overlay policy #3335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
38cc3da
Fix compact hover popover flicker
dillonzq Sep 9, 2026
e73b548
Clear hover timeout when entering compact view
dillonzq Sep 9, 2026
eb017ed
Share responsive overlay presentation and hover policy
ymichael Sep 11, 2026
59b62b1
Merge remote-tracking branch 'origin/main' into bb/review-and-finish-…
ymichael Sep 11, 2026
f20d2e5
Update compact hover candidate with shared policy
ymichael Sep 11, 2026
f96fee0
Remove hover hook test as requested
ymichael Sep 11, 2026
52bec10
Regenerate responsive overlay registry entry
ymichael Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions apps/app/src/components/ui/hooks/use-hover-popover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useCallback, useEffect, useRef, useState } from "react";
import { usePointerCoarse } from "@bb/shared-ui/hooks/use-pointer-coarse";
import { useResponsiveOverlayBehavior } from "@bb/shared-ui/responsive-overlay";

interface HoverPopoverHandlers {
onBlur: () => void;
Expand Down Expand Up @@ -51,7 +51,7 @@ export function useHoverPopover({
closeDelayMs = DEFAULT_CLOSE_DELAY_MS,
hoverableContent = true,
}: UseHoverPopoverOptions = {}): UseHoverPopoverResult {
const isPointerCoarse = usePointerCoarse();
const { supportsHover } = useResponsiveOverlayBehavior();
const [open, setOpen] = useState(false);
const [isFocusOverTrigger, setIsFocusOverTrigger] = useState(false);
const [isFocusOverContent, setIsFocusOverContent] = useState(false);
Expand All @@ -68,9 +68,8 @@ export function useHoverPopover({
}, []);

useEffect(() => {
if (isPointerCoarse) return;

clearToggleTimeout();
if (!supportsHover) return;

Comment thread
dillonzq marked this conversation as resolved.
if (isFocusOverTrigger || isFocusOverContent) {
if (!open) setOpen(true);
Expand Down Expand Up @@ -106,7 +105,7 @@ export function useHoverPopover({
closeDelayMs,
isFocusOverContent,
isFocusOverTrigger,
isPointerCoarse,
supportsHover,
isPointerOverContent,
isPointerOverTrigger,
open,
Expand Down Expand Up @@ -134,7 +133,7 @@ export function useHoverPopover({
);

const triggerHoverProps = {
...(isPointerCoarse
...(!supportsHover
? EMPTY_HOVER_PROPS
: {
onPointerEnter: () => {
Expand All @@ -149,7 +148,7 @@ export function useHoverPopover({
};

const contentHoverProps = {
...(isPointerCoarse
...(!supportsHover
? EMPTY_HOVER_PROPS
: hoverableContent
? {
Expand Down
Loading
Loading