Allow retrying recoverable desktop startup failures - #3224
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
A transient failure loading the selected desktop server left a static startup error page after the server recovered. The error page could not invoke the existing server-selection recovery flow. Reproduced in actual Electron on main at f41d564.
What changed
Recoverable remote navigation, Connect authentication, and local attachment failures now offer Try again, which reapplies the selected target through the existing desktop flow. Fatal startup, port-conflict, and process-stop errors have no retry button.
The sandboxed preload sends a fixed, argument-free IPC event. Main accepts it only from a registered application window's main frame displaying the current retryable error. Retry state is consumed synchronously and only one attempt runs at a time. This prevents rapid clicks from initiating overlapping target loads; a real Electron regression observed three loads for ten clicks before the guard.
No automatic reconnection system, server/daemon wire changes, configuration, CLI, or public plugin API changes. No host-daemon protocol-version bump is needed.
How you verified
pnpm start:worktree; browser-only coverage is not counted as Electron IPC coverage.Fixes #3223