Skip to content

#12547 Default format for feature info depends on last map opened + dpcumentation to fix#12548

Merged
dsuren1 merged 6 commits into
geosolutions-it:masterfrom
Binabh:fix/default-info-sheet-format
Jul 9, 2026
Merged

#12547 Default format for feature info depends on last map opened + dpcumentation to fix#12548
dsuren1 merged 6 commits into
geosolutions-it:masterfrom
Binabh:fix/default-info-sheet-format

Conversation

@Binabh

@Binabh Binabh commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Default config is not being set in reducer so it is taking the last config.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#12547

What is the new behavior?
Last config does not affect config on next map. Also updated Jsdoc in Identify Plugin to reflect what it is currently doing.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@Binabh Binabh added this to the 2026.03.00 milestone Jun 25, 2026
@Binabh Binabh requested a review from allyoucanmap June 25, 2026 10:59
@Binabh Binabh added the bug label Jun 25, 2026
@cla-bot cla-bot Bot added the CLA Ready label Jun 25, 2026
@allyoucanmap allyoucanmap requested review from dsuren1 and removed request for allyoucanmap July 7, 2026 13:32
@allyoucanmap allyoucanmap assigned dsuren1 and unassigned allyoucanmap Jul 7, 2026

@dsuren1 dsuren1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Binabh Could you please check and fix the failing unit tests

@Binabh

Binabh commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@dsuren1 Sure I will look into it.

@dsuren1

dsuren1 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@dsuren1 Sure I will look into it.

@Binabh Looks like the same tests are failing here too. Double check if not abd fix the ones caused by this PR alone and ignore the rest, as there is a PR to fix the floating point ones

@Binabh

Binabh commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@dsuren1 checks have passed. Looks like syncing with master fixed it.

@Binabh Binabh requested a review from dsuren1 July 9, 2026 11:47
@dsuren1 dsuren1 merged commit 35d5c18 into geosolutions-it:master Jul 9, 2026
12 checks passed
@dsuren1

dsuren1 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@ElenaGallo Kindly test it in DEV when available. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default format for feature info depends on last map opened + dpcumentation to fix

3 participants