F gpu 2196 by plyhun · Pull Request #1750 · gentics/mesh

plyhun · 2026-03-03T13:14:54Z

Abstract

Checklist

General

Added abstract that describes the change
Added changelog entry to /CHANGELOG.adoc
Ensured that the change is covered by tests
Ensured that the change is documented in the docs

On API Changes

Checked if the changes are breaking or not
Added GraphQL API if applicable
Added Elasticsearch mapping if applicable

plyhun · 2026-03-03T14:29:59Z

+	@JsonProperty(required = false)
+	@JsonPropertyDescription("Should the endpoints of the included plugins be excluded from the OpenAPI specification generation requests. Default is true.")
+	@EnvironmentVariable(name = MESH_OPENAPI_EXCLUDE_PLUGINS_ENV, description = "Override the flag to exclude endpoints of the plugins from the OpenAPI specification generation requests")
+	private boolean openapiExcludePlugins = true;


Should we exclude plugins by default?

plyhun · 2026-03-03T14:46:42Z

 		revokePermissionsEndpoint.exampleRequest(roleExamples.getObjectPermissionRevokeRequest(includePublishPermissions));
 		revokePermissionsEndpoint.exampleResponse(OK, roleExamples.getObjectPermissionResponse(includePublishPermissions), "Updated permissions.");
 		revokePermissionsEndpoint.events(ROLE_PERMISSIONS_CHANGED);
+		revokePermissionsEndpoint.setHidden(true);


DELETE request with a body are not allowed in the v3.0 specification, so while the direct http calls will still work, we hide this from the generator and redefine an identical PUT request below.

plyhun · 2026-03-03T14:48:11Z

+	 * @throws OpenAPIGenerationException 
+	 */
+	public void run() throws IOException, OpenAPIGenerationException {
+		String yaml = generate("yaml");


Generate yaml to be consistent with RAML generator output.

plyhun · 2026-03-25T13:52:36Z

 		}, isOrderedBlockingHandlers());

 		InternalEndpointRoute readEndpoint = createRoute();
-		readEndpoint.path("/plugins/:uuid");


plyhun · 2026-03-25T13:54:10Z

+
 		secure("/");
 		InternalEndpointRoute infoEndpoint = createRoute();
+		infoEndpoint.setInsecure(true);


Is actually accessible with no auth, giving back different info for anonymous user.

plyhun · 2026-03-25T13:56:24Z

 			crudHandler.handleSetLatest(ac, uuid);
 		}, isOrderedBlockingHandlers());

+		InternalEndpointRoute upsertBranch = createRoute();


Here we explicitly tell apart update and upsert EPs for all models, since the specification requires different body models for create and update actions. The backwards compatibility is kept.

plyhun · 2026-03-31T10:02:33Z

-		revokePermissionsEndpoint.exampleResponse(OK, roleExamples.getObjectPermissionResponse(false), "Updated permissions.");
-		revokePermissionsEndpoint.events(ROLE_PERMISSIONS_CHANGED);
-		revokePermissionsEndpoint.blockingHandler(rc -> {
+		InternalEndpointRoute revokePermissionsEndpointNonStandard = createRoute();


DELETE method with a body is not allowed by a spec.

plyhun · 2026-03-31T10:12:12Z

 import java.util.stream.Stream;

-import org.codehaus.jettison.json.JSONException;
-import org.codehaus.jettison.json.JSONObject;


Using other JSON implementation is awkward.

plyhun · 2026-03-31T10:14:10Z

 			}
 			config.setInstanceName(options.getNodeName());
-			config.setClusterName(options.getClusterOptions().getClusterName());
+			config.setClusterName(Optional.ofNullable(options.getClusterOptions().getClusterName()).orElseGet(() -> options.getNodeName()));


Null safety.

plyhun · 2026-03-31T10:14:53Z

+		String format = formatConf.name().toLowerCase();
+
+		// Collect available servers
+		HttpServerConfig httpServerConfig = options.getHttpServerOptions();	


Can be reverted, if considered a vulnerability.

plyhun · 2026-03-31T10:19:03Z

+		defaultMapper = JsonMapper.builder(new JsonFactoryBuilder()
+				.streamReadConstraints(StreamReadConstraints.builder().maxStringLength(Integer.MAX_VALUE).build())
+				.build())
+				.enable(MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS)


Already used (at least) in the tests, so formalized for the model generation.

plyhun · 2026-03-31T10:19:49Z

@@ -26,6 +26,6 @@ default BackupParameters setConsistencyCheck(boolean flag) {
 	 * @return
 	 */
 	default boolean isConsistencyCheck() {


Null values were improperly processed with valueOf.

plyhun · 2026-03-31T10:25:47Z

+import io.vertx.core.json.JsonObject;
+
+/**
+ * An upgrade to the generated DefaultAPI, overriding its generation problems 


Even though the text/* string body is defined for the method in the spec, okhttp3-gson client generator forgets about it.

…s config

…foPlugins config" This reverts commit bc56fc5.

Increase memory limits for Maven and adjust environment variables.

This reverts commit edee7e9.

plyhun requested a review from npomaroli March 3, 2026 13:14

plyhun commented Mar 3, 2026

View reviewed changes

plyhun commented Mar 25, 2026

View reviewed changes

plyhun commented Mar 31, 2026

View reviewed changes

plyhun added 16 commits July 17, 2026 11:55

OpenAPI working VERY incomplete implementation

404d8a8

Type schema fill

5a7cd8c

Components filled

f87091e

Security layer. Better type support.

0f66539

Off the System.outs

82d5808

Build fixes

8136cf5

Improved result

8e349f7

Minor fixes

f97b828

JRE 9+ Runtime fix

cf83d67

Works

ff72ff5

Java client generated, built and able to login

15acd23

Correct spec types

eb43633

Runtime based generation

70c688d

Generates

bf07464

Refactoring pt1

b8ead02

REST API refactor + tests base

714cb1c

plyhun and others added 29 commits July 17, 2026 12:17

OpenAPI killswitch

3a9760d

Plugin routes are secured by default

f0a4073

Allow running skipping doc

8349053

Changelog actualized

3e6c032

Make eventbus completely hidden to the OpenAPI

5f3725a

Make the test assertion overridable

994651b

Missing dependency

fbcb61d

Spect validation fixes

fefeee6

Tell apart update and upsert endpoints, as OpenAPI spec forbids it

1f40f25

Regression

e2de92e

Regression

6ef5fd7

Regression

ef2e6a4

Remove dead APIs. Minor fixes. Client impl.

8d5f512

Add backOfficeAuth/cleanupSecret security schemes and noApiInfoPlugin…

724ec76

…s config

Revert "Add backOfficeAuth/cleanupSecret security schemes and noApiIn…

1162ccd

…foPlugins config" This reverts commit bc56fc5.

Test client almost done

5eae277

Generated client fullfilled

1a84027

Generated client fixes

6de9344

Regression of the JsonSchema generation and the generated Java client

0075683

Fix OpenAPI feature possibilities in references.asciidoc

1939b3b

OOM fix

2ee04b5

Upsert parameter

fac0a8e

Revert optional entity upsert

a258dc1

Other fixes

42e9748

Update Maven options and environment variables in Jenkinsfile

32867a9

Increase memory limits for Maven and adjust environment variables.

Revert "Update Maven options and environment variables in Jenkinsfile"

9cdaab6

This reverts commit edee7e9.

Fix the tests

ded34ee

Auth token test fix

2e17052

Compiles

0394680

plyhun force-pushed the f-gpu-2196 branch from 836825c to 0394680 Compare July 17, 2026 14:11

Uh oh!

Conversation

plyhun commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Abstract

Checklist

General

On API Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

plyhun commented Mar 3, 2026 •

edited

Loading