Repository navigation
make formatting of unterminated interpolations idempotent - #261
Merged
g-plane merged 1 commit intoSep 21, 2026
Merged
Conversation
✅ Deploy Preview for markup-fmt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
g-plane
requested changes
Sep 21, 2026
UnknownPlatypus
force-pushed
the
fix-unterminated-interpolation
branch
from
September 21, 2026 07:30
2205530 to
25919f6
Compare
An interpolation running to EOF was recovered by taking the rest of the source
as its expression, then printed with a closing `}}`. Since the expression
scanner matches braces and quotes, the unbalanced opener left in the content
swallowed one of those braces on the next parse, which appended another one:
`{{{` became `{{ { }}`, then `{{ { } }}`, growing on every pass.
Unterminated interpolations are now a syntax error, like the unclosed tags and
Angular block parameters already are.
UnknownPlatypus
force-pushed
the
fix-unterminated-interpolation
branch
from
September 21, 2026 07:34
25919f6 to
754f588
Compare
g-plane
approved these changes
Sep 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interpolation running to EOF was recovered by taking the rest of the source as its expression, closed with a
}}.Since the expression scanner matches braces and quotes, any unbalanced opener left in the content swallowed one of those braces on the next parse, which appended another one.
{{{became{{ { }}then{{ { } }}, growing on every pass.Unterminated interpolations are now a syntax error, like the unclosed tags and Angular block parameters already are.