Repository navigation
build(packages): exclude *.test.ts and *.spec.ts from builds - #143
Merged
Merged
Conversation
…from builds The tsconfig exclude globs only matched *_test.ts, so src/number/numRange.test.ts was compiled and its declaration was emitted to dist/esm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
excludeglobs in the package tsconfigs only matched*_test.ts, sosrc/number/numRange.test.tswas compiled and its declaration ended up indist/esm. This addssrc/**/*.test.tsandsrc/**/*.spec.tsto all five package tsconfigs.Closes #135
Testing
pnpm build: no*.test.*or*.spec.*files underpackages/*/distnpx tsc --noEmit -p packages/fjl/tsconfig.json: cleanpnpm test: 133 suites and 1457 tests pass, andnumRange.test.tsis still picked up🤖 Generated with Claude Code