Skip to content

CI: publish to Docker Hub only, drop GHCR #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fakebizprez merged 2 commits into from
Jun 27, 2026
Merged

CI: publish to Docker Hub only, drop GHCR #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d6389f
skillz
fakebizprez Jun 27, 2026
8aff0d8
CI: publish to Docker Hub only, drop GHCR
fakebizprez Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"enabledPlugins": {
"superpowers-developing-for-claude-code@superpowers-marketplace": true,
"frontend-design@claude-plugins-official": true
"frontend-design@claude-plugins-official": true,
"pr-review-toolkit@claude-plugins-official": true
}
}
Comment on lines 1 to 7

@llamapreview llamapreview Bot Jun 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 | Confidence: Medium

Speculative: The PR bundles an unrelated change to the AI assistant plugin configuration (pr-review-toolkit added) alongside the core CI fix. While the plugin addition is presumably intentional, mixing two logically independent changes in a single pull request reduces traceability, complicates release notes, and makes rollback more error-prone if either change needs to be reverted. No deterministic failing path is visible in the changed snippet, but the pattern violates the principle of single responsibility for commits/PRs.

10 changes: 0 additions & 10 deletions .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,13 @@ on:
workflow_dispatch:

env:
GHCR_IMAGE: ghcr.io/${{ github.repository }}
DOCKERHUB_IMAGE: ${{ secrets.DOCKERHUB_USERNAME }}/streamlit-network

jobs:
build-and-push:
runs-on: ubuntu-latest
permissions:
contents: read
packages: write

steps:
- name: Checkout repository
Expand All @@ -29,13 +27,6 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to GitHub Container Registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Login to Docker Hub
if: github.event_name != 'pull_request'
uses: docker/login-action@v3
Expand All @@ -48,7 +39,6 @@ jobs:
uses: docker/metadata-action@v5
with:
images: |
${{ env.GHCR_IMAGE }}
${{ env.DOCKERHUB_IMAGE }}
tags: |
type=raw,value=latest,enable=${{ github.ref == 'refs/heads/master' }}
Expand Down
Loading