Skip to content

Refactor project import functionality to support zip file uploads and enforce size limits#559

Open
stijnpotters1 wants to merge 6 commits into
masterfrom
fix/import-project-zipping
Open

Refactor project import functionality to support zip file uploads and enforce size limits#559
stijnpotters1 wants to merge 6 commits into
masterfrom
fix/import-project-zipping

Conversation

@stijnpotters1

@stijnpotters1 stijnpotters1 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
image image image image

With a file too big:
image

@stijnpotters1 stijnpotters1 self-assigned this Jun 17, 2026
@stijnpotters1 stijnpotters1 linked an issue Jun 17, 2026 that may be closed by this pull request
@stijnpotters1 stijnpotters1 marked this pull request as draft June 17, 2026 15:30
@stijnpotters1 stijnpotters1 marked this pull request as ready for review June 22, 2026 06:58
@stijnpotters1 stijnpotters1 requested a review from Matthbo June 22, 2026 07:03
@stijnpotters1 stijnpotters1 marked this pull request as draft June 22, 2026 07:31
@stijnpotters1 stijnpotters1 marked this pull request as ready for review June 22, 2026 07:31
@sonarqubecloud

Copy link
Copy Markdown

@Matthbo Matthbo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max uncompressed size is 80MB, but what if you'd want to increase this as a non-developer?
Maybe it should be an app constant so its configurable for the backend and the frontend can request the max upload restrictions from the api

@stijnpotters1

stijnpotters1 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

The max uncompressed size is 80MB, but what if you'd want to increase this as a non-developer? Maybe it should be an app constant so its configurable for the backend and the frontend can request the max upload restrictions from the api

As a non-developer there is no way to increase the 80MB size. Even if we implement a configurable constant in the app that provides the possibility to increase the size, the nginx client_max_body_size will prevent the folder to even end up in the app. This is a global constant in nginx and we can not dynamically change this per client or session

@stijnpotters1 stijnpotters1 requested a review from Matthbo June 23, 2026 10:04
@Matthbo

Matthbo commented Jun 23, 2026

Copy link
Copy Markdown
Member

eloper there is no way to increase the 80MB size. Even if we implement a configurable constant in the app that provides the possibility to increase the size, the nginx client_max_body_size will prevent the folder to even end up in the app. This is a global constant in nginx and we can not dynamically change this per client or session

No but a system admin usually can, not even giving the option means we might walk into this issue sooner or later, giving the system administrator the power to configure it means it will be their problem instead of a technical issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not import configuration folder anymore

2 participants