Skip to content

Improve stderr progress printing in ctr img pulls - #563

Merged
ethanjli merged 4 commits into
mainfrom
img-pull-stderr
Nov 3, 2026
Merged

ethanjli merged 4 commits into
mainfrom
img-pull-stderr

Conversation

@ethanjli

@ethanjli ethanjli commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

This PR resolves #491 by replicating how the Docker CLI displays image pulling progress:

  • When pulling images without parallelism, it displays progress information the same way as the Docker CLI, except the progress information is correctly indented
  • When pulling images with parallelism, it displays progress information just like in pulling images without parallelism, except if progress information is being displayed for image A and then image B finishes being pulled, the progress completion outputs for image B will be displayed for that image, and then the progress information will return to image A. Otherwise, there is no interleaving of progress information between images.

This PR also bumps github.com/urfave/cli from v4 to v5.

@ethanjli
ethanjli enabled auto-merge November 3, 2026 14:16
@ethanjli
ethanjli added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 3, 2026
@ethanjli
ethanjli enabled auto-merge November 3, 2026 15:09
@ethanjli
ethanjli added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 675a70e Nov 3, 2026
2 checks passed
@ethanjli
ethanjli deleted the img-pull-stderr branch November 3, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui: Provide TUI output of container image download progress

1 participant