Skip to content

Add helm-chart-fluid-1.1.0-alpha.10 - #119

Merged
RongGu merged 1 commit into
fluid-cloudnative:masterfrom
cheyang:helm-chart-fluid-1.1.0-alpha.10
Jul 12, 2026
Merged

Add helm-chart-fluid-1.1.0-alpha.10#119
RongGu merged 1 commit into
fluid-cloudnative:masterfrom
cheyang:helm-chart-fluid-1.1.0-alpha.10

Conversation

@cheyang

@cheyang cheyang commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: cheyang <cheyang@163.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Fluid chart and application versions, and introduces support for configuring feature gates across various runtime controllers (Alluxio, Jindo, JuiceFS, Thin, and Vineyard). It also updates the Go builder image in the E2E test Dockerfile. The reviewer suggests explicitly defining the featureGates: "" key under each runtime configuration in values.yaml to improve discoverability and self-documentation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread charts/fluid/values.yaml
Comment on lines +134 to +139
# featureGates is a comma-separated list of feature gates for alluxioruntime controller.
# RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
# Alpha; may change or be removed in future releases.
# Disabled by default for security; the default is compiled into the controller binary and
# applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
# Enable only if you trust all users with AlluxioRuntime CR update permissions.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the comments describe the featureGates parameter, the key itself is not defined in values.yaml. Explicitly defining featureGates: "" makes the chart configuration more discoverable and self-documenting for users and automated tools.

    # featureGates is a comma-separated list of feature gates for alluxioruntime controller.
    # RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
    #   Alpha; may change or be removed in future releases.
    #   Disabled by default for security; the default is compiled into the controller binary and
    #   applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
    #   Enable only if you trust all users with AlluxioRuntime CR update permissions.
    featureGates: ""

Comment thread charts/fluid/values.yaml
Comment on lines +180 to +185
# featureGates is a comma-separated list of feature gates for jindoruntime controller.
# RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
# Alpha; may change or be removed in future releases.
# Disabled by default for security; the default is compiled into the controller binary and
# applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
# Enable only if you trust all users with JindoRuntime/JindoFSxRuntime/JindoCacheRuntime CR update permissions.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Explicitly defining featureGates: "" under the jindo runtime configuration makes the parameter discoverable and self-documenting.

    # featureGates is a comma-separated list of feature gates for jindoruntime controller.
    # RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
    #   Alpha; may change or be removed in future releases.
    #   Disabled by default for security; the default is compiled into the controller binary and
    #   applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
    #   Enable only if you trust all users with JindoRuntime/JindoFSxRuntime/JindoCacheRuntime CR update permissions.
    featureGates: ""

Comment thread charts/fluid/values.yaml
Comment on lines +223 to +228
# featureGates is a comma-separated list of feature gates for juicefsruntime controller.
# RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
# Alpha; may change or be removed in future releases.
# Disabled by default for security; the default is compiled into the controller binary and
# applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
# Enable only if you trust all users with JuiceFSRuntime CR update permissions.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Explicitly defining featureGates: "" under the juicefs runtime configuration makes the parameter discoverable and self-documenting.

    # featureGates is a comma-separated list of feature gates for juicefsruntime controller.
    # RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
    #   Alpha; may change or be removed in future releases.
    #   Disabled by default for security; the default is compiled into the controller binary and
    #   applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
    #   Enable only if you trust all users with JuiceFSRuntime CR update permissions.
    featureGates: ""

Comment thread charts/fluid/values.yaml
Comment on lines +260 to +265
# featureGates is a comma-separated list of feature gates for thinruntime controller.
# RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
# Alpha; may change or be removed in future releases.
# Disabled by default for security; the default is compiled into the controller binary and
# applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
# Enable only if you trust all users with ThinRuntime CR update permissions.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Explicitly defining featureGates: "" under the thin runtime configuration makes the parameter discoverable and self-documenting.

    # featureGates is a comma-separated list of feature gates for thinruntime controller.
    # RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
    #   Alpha; may change or be removed in future releases.
    #   Disabled by default for security; the default is compiled into the controller binary and
    #   applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
    #   Enable only if you trust all users with ThinRuntime CR update permissions.
    featureGates: ""

Comment thread charts/fluid/values.yaml
Comment on lines +331 to +336
# featureGates is a comma-separated list of feature gates for vineyardruntime controller.
# RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
# Alpha; may change or be removed in future releases.
# Disabled by default for security; the default is compiled into the controller binary and
# applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
# Enable only if you trust all users with VineyardRuntime CR update permissions.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Explicitly defining featureGates: "" under the vineyard runtime configuration makes the parameter discoverable and self-documenting.

    # featureGates is a comma-separated list of feature gates for vineyardruntime controller.
    # RuntimeFuseHostPID: Controls whether the runtime.fluid.io/fuse.hostpid annotation can enable hostPID in FUSE DaemonSets.
    #   Alpha; may change or be removed in future releases.
    #   Disabled by default for security; the default is compiled into the controller binary and
    #   applies when featureGates is unset, so there is no need to set RuntimeFuseHostPID=false here.
    #   Enable only if you trust all users with VineyardRuntime CR update permissions.
    featureGates: ""

@RongGu RongGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@RongGu
RongGu merged commit 6928a66 into fluid-cloudnative:master Jul 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants