Skip to content

docs: pipeline: inputs: syslog: document empty newline frame handling - #2759

Merged
eschabell merged 1 commit into
fluent:masterfrom
eschabell:erics_in_syslog_empty_newline_frames
Oct 9, 2026
Merged

eschabell merged 1 commit into
fluent:masterfrom
eschabell:erics_in_syslog_empty_newline_frames

Conversation

@eschabell

@eschabell eschabell commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator
  • Document that empty lines are ignored when using TCP modes with newline framing

Signed-off-by: Eric D. Schabell eric@schabell.org

Summary by CodeRabbit

  • Documentation
    • Clarified that Fluent Bit v5.1.3 and later skips empty lines and creates no records for them when Syslog uses TCP with newline framing.

  - Document that empty lines are ignored when using TCP modes with newline framing

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell requested review from a team and patrick-stephens as code owners October 6, 2026 19:15
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6c2bd273-3259-4b2e-91f8-e03fa8ad998b
📥 Commits

Reviewing files that changed from the base of the PR and between e586da8 and 75732b9.

📒 Files selected for processing (1)
  • pipeline/inputs/syslog.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The Syslog input documentation adds a note that Fluent Bit v5.1.3 or later ignores empty lines in TCP modes using newline framing and does not produce records for them.

Changes

Syslog documentation update

Layer / File(s) Summary
Document empty-line behavior
pipeline/inputs/syslog.md
The documentation describes how Fluent Bit v5.1.3 or later handles empty lines when Syslog uses TCP with newline framing.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 75732

The version- and mode-specific note matches the implementation; no actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the documentation change for empty newline frame handling in the Syslog input pipeline.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eschabell eschabell self-assigned this Oct 6, 2026
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.1.3 labels Oct 6, 2026
@eschabell

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eschabell

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eschabell

Copy link
Copy Markdown
Collaborator Author

@patrick-stephens ready for review!

@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Oct 9, 2026
@eschabell
eschabell merged commit ed3e6fd into fluent:master Oct 9, 2026
8 checks passed
@eschabell
eschabell deleted the erics_in_syslog_empty_newline_frames branch October 9, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants