Skip to content

docs: pipeline: outputs: gcs: gate total_file_size and net.* to v5.1.3 - #2736

Merged
eschabell merged 1 commit into
fluent:masterfrom
eschabell:erics_out_gcs_gate_updates
Sep 26, 2026
Merged

eschabell merged 1 commit into
fluent:masterfrom
eschabell:erics_out_gcs_gate_updates

Conversation

@eschabell

@eschabell eschabell commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Neither feature documented by PR #2716 is present in v5.1.2 or any
earlier tag. Both ship in v5.1.3.

  • Annotate the total_file_size row and scope the two Buffering
    paragraphs that describe the size based upload trigger.
  • Scope the net.* bullet under Networking and TLS configuration.
    flb_upstream_create is present in v5.1.2, but
    flb_output_upstream_set is not, so net.* properties set on a GCS
    output had no effect in released builds.

The GCS plugin itself shipped in v5.1 and is unaffected, as is the
tls.* bullet.

Refs #2727

Summary by CodeRabbit

  • Documentation
    • Clarified that size-triggered uploads and upload-connection net.* settings are supported in Fluent Bit 5.1.3 and later.
    • Clarified that timeout-triggered uploads are available across versions, and that net.* settings do not apply to credential-service or metadata-server connections.

  Neither feature documented by PR fluent#2716 is present in v5.1.2 or any
  earlier tag. Both ship in v5.1.3.

  - Annotate the total_file_size row and scope the two Buffering
    paragraphs that describe the size based upload trigger.
  - Scope the net.* bullet under Networking and TLS configuration.
    flb_upstream_create is present in v5.1.2, but
    flb_output_upstream_set is not, so net.* properties set on a GCS
    output had no effect in released builds.

  The GCS plugin itself shipped in v5.1 and is unaffected, as is the
  tls.* bullet.

  Refs fluent#2727

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell requested review from a team and patrick-stephens as code owners September 26, 2026 13:45
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9889b14a-8a3a-48fc-8b32-5417480e90ea

📥 Commits

Reviewing files that changed from the base of the PR and between 7279bf6 and d443268.

📒 Files selected for processing (1)
  • pipeline/outputs/gcs.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The GCS output documentation now identifies Fluent Bit 5.1.3 as the minimum version for size-triggered uploads and limits net.* settings to the GCS upload connection in that version and later.

Changes

GCS Output Documentation

Layer / File(s) Summary
Document version-specific GCS behavior
pipeline/outputs/gcs.md
The documentation distinguishes timeout-triggered uploads from size-triggered uploads. It scopes size-trigger behavior and net.* settings for the GCS upload connection to Fluent Bit 5.1.3 and later.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to d4432

The GCS documentation accurately describes these version-specific behaviors; no actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to d4432

The change affects 1 system.

Changed systems: pipeline

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pipeline (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pipeline/outputs/gcs.md: The total_file_size description now identifies the size trigger as supported in Fluent Bit 5.1.3 or later.
  • observed — Modified behavior in pipeline/outputs/gcs.md: Buffering documentation now states that timeout-triggered uploads apply generally, while uploads triggered when a tag’s current file reaches total_file_size are available from version 5.1.3. The size-trigger paragraph now explicitly scopes its sealing, immediate-upload scheduling, batch-size caveat, zero-value behavior, and minimum-size startup failure to that version and later.
  • observed — Modified behavior in pipeline/outputs/gcs.md: The networking note now limits application of net.* settings to the GCS upload connection in Fluent Bit 5.1.3 and later; those settings still do not apply to connections for token exchange, IAM credentials, or metadata-server access.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main documentation change. It identifies the affected GCS settings and the v5.1.3 version boundary.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eschabell eschabell self-assigned this Sep 26, 2026
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.1.2 labels Sep 26, 2026
@eschabell
eschabell merged commit 8921807 into fluent:master Sep 26, 2026
8 checks passed
@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants