Skip to content

docs: pipeline: outputs: opensearch: gate drop_unrecoverable_records to v5.1.3 - #2735

Merged
eschabell merged 1 commit into
fluent:masterfrom
eschabell:erics_out_opensearch_gate_updates
Sep 26, 2026
Merged

eschabell merged 1 commit into
fluent:masterfrom
eschabell:erics_out_opensearch_gate_updates

Conversation

@eschabell

@eschabell eschabell commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

drop_unrecoverable_records is not present in v5.1.2 or any earlier tag.
Upstream commit 54f00f219 added it along with the bulk failure summary
log, and both ship in v5.1.3.

  • Annotate the configuration parameters row.
  • Scope the Bulk retries paragraph that introduces the option.
  • Scope the failure summary paragraph, and split its first sentence to
    stay under the 35 word vale limit.

The per-document payload rebuild described earlier in that section is
left ungated. retry_payload and next_retry_payload are both present in
v5.1.2, so that filtering, and its trace record carve-out, are accurate
for current releases.

Refs #2727

Summary by CodeRabbit

  • Documentation
    • Clarified that drop_unrecoverable_records and bulk-failure summaries are available in Fluent Bit 5.1.3 and later.

…to v5.1.3

  drop_unrecoverable_records is not present in v5.1.2 or any earlier tag.
  Upstream commit 54f00f219 added it along with the bulk failure summary
  log, and both ship in v5.1.3.

  - Annotate the configuration parameters row.
  - Scope the Bulk retries paragraph that introduces the option.
  - Scope the failure summary paragraph, and split its first sentence to
    stay under the 35 word vale limit.

  The per-document payload rebuild described earlier in that section is
  left ungated. retry_payload and next_retry_payload are both present in
  v5.1.2, so that filtering, and its trace record carve-out, are accurate
  for current releases.

  Refs fluent#2727

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell requested review from a team and patrick-stephens as code owners September 26, 2026 12:51
@eschabell eschabell self-assigned this Sep 26, 2026
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ca2c0a75-da7d-4a2b-9b6d-cb8469878c0b

📥 Commits

Reviewing files that changed from the base of the PR and between 7279bf6 and c04be47.

📒 Files selected for processing (1)
  • pipeline/outputs/opensearch.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The OpenSearch output documentation now specifies Fluent Bit 5.1.3 and later for drop_unrecoverable_records and the documented unrecoverable-record behavior. Other documented behavior remains unchanged.

Changes

OpenSearch output version documentation

Layer / File(s) Summary
Document version support
pipeline/outputs/opensearch.md
The option description and unrecoverable-record behavior documentation now specify Fluent Bit 5.1.3 and later. The documented status rules, retries, trace-record exclusion, and dropped-record metric remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to c04be

No concrete merge-blocking issue was established. The documentation change is consistent with the available implementation history.

Architecture Summary

Architecture risk: 🔵 Low · up to c04be

The change affects 1 system.

Changed systems: pipeline

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pipeline (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pipeline/outputs/opensearch.md: The drop_unrecoverable_records description now states that the option is supported in Fluent Bit 5.1.3 or later.
  • observed — Modified behavior in pipeline/outputs/opensearch.md: The documentation now limits the unrecoverable-record dropping behavior and bulk-failure error summary to Fluent Bit 5.1.3 and later. The documented status rules, retries, trace-record exclusion, and dropped-record metric remain unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the documentation change: gating drop_unrecoverable_records to Fluent Bit v5.1.3.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.1.2 labels Sep 26, 2026
@eschabell

Copy link
Copy Markdown
Collaborator Author

@patrick-stephens ready for review!

@eschabell
eschabell merged commit 82cb964 into fluent:master Sep 26, 2026
8 checks passed
@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants