Repository navigation
docs: pipeline: parsers: json: document nesting depth limit - #2732
Merged
eschabell merged 1 commit intoOct 9, 2026
Merged
Conversation
Add a Nesting depth limit section covering the 32 level cap the JSON
parser applies when converting log entries to the internal binary
representation:
- The outermost object counts as the first level.
- Entries nested deeper fail to parse.
- The rejection is silent, so such a record is indistinguishable from
one rejected for malformed JSON.
Upstream commit 78b8e42bb bounded yyjson_val_to_msgpack(), which
recursed without a limit in v5.1.2 and earlier.
Signed-off-by: Eric D. Schabell <eric@schabell.org>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Set as draft waiting on 5.1.3 release. |
eschabell
marked this pull request as ready for review
October 6, 2026 17:59
Collaborator
Author
|
@patrick-stephens ready for review, 5.1.3 dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Nesting depth limit section covering the 32 level cap the JSON
parser applies when converting log entries to the internal binary
representation:
one rejected for malformed JSON.
Upstream commit 78b8e42bb bounded yyjson_val_to_msgpack(), which
recursed without a limit in v5.1.2 and earlier.