You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reject transcript timestamps containing impossible calendar dates before parsing them. Valid leap days, fractional seconds, and timezone offsets remain supported.
Why
JavaScript's Date.parse() normalizes impossible dates, such as February 31, into dates in the following month. This can cause transcript timestamps to disagree with the parsed instants used by deadline checks.
Thanks for addressing #188. Heads-up that #190, opened earlier, already implements the same calendar-date rejection in src/transcript.ts, with regression cases for invalid February/April dates, valid leap days, fractional seconds and offsets. Its exact-head fork CI passed the full build and 177 tests: https://github.com/maho0638/tclk/actions/runs/37065379276. The implementations differ in shape/error wording, but appear to close the same issue; only one should merge. Flagging the overlap so reviewers can compare them and select a single implementation rather than spending time resolving avoidable conflicts.
Thanks for addressing #188. Heads-up that #190, opened earlier, already implements the same calendar-date rejection in src/transcript.ts, with regression cases for invalid February/April dates, valid leap days, fractional seconds and offsets. Its exact-head fork CI passed the full build and 177 tests: https://github.com/maho0638/tclk/actions/runs/37065379276. The implementations differ in shape/error wording, but appear to close the same issue; only one should merge. Flagging the overlap so reviewers can compare them and select a single implementation rather than spending time resolving avoidable conflicts.
Thanks for the heads-up and for reviewing the overlap. I wasn’t aware of PR #190 when I started working on issue #188.
My implementation includes regression tests for impossible February and April dates, plus a valid leap day. I understand that only one implementation should be merged, and I’m happy to defer to the maintainers on which solution is best.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reject transcript timestamps containing impossible calendar dates before parsing them. Valid leap days, fractional seconds, and timezone offsets remain supported.
Why
JavaScript's
Date.parse()normalizes impossible dates, such as February 31, into dates in the following month. This can cause transcript timestamps to disagree with the parsed instants used by deadline checks.Closes #188
Checks
pnpm -r --include-workspace-root buildpnpm -r --include-workspace-root testCHANGELOG.mdhas an[Unreleased]entry