Fleet UI: Multi-package add-conflict error copy (#49309)#49336
Open
RachelElysia wants to merge 2 commits into
Open
Fleet UI: Multi-package add-conflict error copy (#49309)#49336RachelElysia wants to merge 2 commits into
RachelElysia wants to merge 2 commits into
Conversation
…fic error copy The frontend was collapsing every "already ..." backend conflict into the generic "installer available" flash. Match on the specific tail of each backend message (FMA / VPP / software package / 10-package limit) and render the design copy with the software title and fleet name bolded. Handle the "different file type" error at the callsite so we can prepend the title from form context, and plumb the title into the Software title Add-package modal.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/28108-multiple-custom-packages #49336 +/- ##
======================================================================
Coverage ? 65.73%
======================================================================
Files ? 3768
Lines ? 239429
Branches ? 12725
======================================================================
Hits ? 157387
Misses ? 67220
Partials ? 14822
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Quick pass — mostly clean, a few small notes. Feature-branch base so nothing here is release-critical. Should fix
Nit
Nice
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #49309.
Description
The frontend collapses every backend
"already ..."conflict into the generic"installer available"flash, wiping the FMA / VPP / package-limit specificity from the design. This routes each backend message to its design-specific copy (title + fleet bolded), and handles the"different file type"error at the two Custom Package callsites by prepending the title from form context.Also plumbs the software title through
SoftwareTitleDetailsPage→AddPackageModalso the multi-package modal can produce the same design copy.Screenrecording
Testing