Skip to content

SDL2_image: Disable stb_image - #533

Merged
orowith2os merged 1 commit into
flathub:masterfrom
user1-github:patch-1
Nov 22, 2026
Merged

orowith2os merged 1 commit into
flathub:masterfrom
user1-github:patch-1

Conversation

@user1-github

Copy link
Copy Markdown
Contributor

No description provided.

@tothxa tothxa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Since this comment from the main developer of SDL doesn't apply to us, as we already have those external libs, the performance issues indeed settle the matter.

@user1-github

user1-github commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Ok, are you able to merge this?

It seems I can't merge this, I guess because I didn't originally submit SDL2_image. Though it's weird, because since we're both codeowners for the entire SDL2 namespace in this repo, I think it shouldn't matter.

@orowith2os Maybe I need to receive a flathubbot invite to the shared-modules repo to be able to merge PRs?
I originally added myself as SDL2 codeowner in a PR that added SDL2_mixer, and I don't remember receiving an invite.

@orowith2os

Copy link
Copy Markdown
Member

Yes, please file an issue on https://github.com/flathub/flathub to receive access, or I can merge manually, as I will do now.

@orowith2os
orowith2os merged commit 34add58 into flathub:master Nov 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants