Conversation
The register-input response now reports publish_url in place of port, so the caller no longer has to build an address from the composition origin and a port. Regenerated the composition client, which also picks up the 503 the endpoint can now answer with.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are consistent across client, generated types, and tests, and the updated behavior is explicitly covered by new test cases.
Pull request overview
This PR updates the Composition API client to return the full RTMP publish URL from register_rtmp_input, reflecting a server-side change where the publish address can no longer be derived from the composition origin + port.
Changes:
- Updated
CompositionClient.register_rtmp_inputto return astrpublish URL and raiseInternalServerErrorwhen it’s missing. - Regenerated Composition OpenAPI client pieces to replace
RegisterInputResponse.portwithpublish_urland to parse documented503responses for input registration. - Added/updated tests covering the new return value and the missing-publish-url error case.
File summaries
| File | Description |
|---|---|
| tests/test_composition.py | Adds RTMP publish URL fixtures and tests the new return value + missing-address error behavior. |
| fishjam/api/_composition_client.py | Changes register_rtmp_input to return the server-chosen publish URL and error if absent. |
| fishjam/_composition_openapi_client/models/register_input_response.py | Replaces port with publish_url in the generated response model. |
| fishjam/_composition_openapi_client/api/inputs/register_input.py | Updates the generated response parsing to handle 503 as an ApiError. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The composition API now reports a complete RTMP publish URL where it previously reported only a port.
RegisterInputResponse.portis replaced bypublish_url, and register-input handles the 503 it can now answer withregister_rtmp_inputreturns the publish URL instead ofNone, raisingInternalServerErrorwhen the server omits itMotivation and Context
The publish address can no longer be derived from the composition origin and a port, so the server supplies the whole URL.
Documentation impact
Types of changes