Repository navigation
DEX-2185: remind the releaser to mark each new fireblocks-sdk version deprecated - #346
Closed
mottymilshtein wants to merge 2 commits into
Closed
mottymilshtein wants to merge 2 commits into
mottymilshtein wants to merge 2 commits into
Conversation
…each release npm deprecate only marks versions that already exist, so a release published after the package is deprecated would install without a warning. The publish job now re-runs npm deprecate right after publishing and fails unless the new version carries the mark. OIDC trusted publishing cannot run npm deprecate, so the step uses an NPM_DEPRECATE_TOKEN repository secret.
… an npm token This repo publishes through OIDC and deliberately holds no npm token, and OIDC cannot run npm deprecate. The step after publish now raises a warning and puts the exact npm deprecate command in the run summary, for a fireblocks-sdk maintainer on npm to run by hand.
mottymilshtein
changed the title
Collaborator
Author
|
Folded into #347, which now covers both DEX-2183 and DEX-2185. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a step to the publish job, after
npm publish, that reminds whoever released to mark the new version deprecated on npm. It raises a warning on the run, and the run summary carries the exactnpm deprecate fireblocks-sdk "…"command to copy.Why
npm deprecateonly marks versions that already exist. A version published after the package is deprecated installs with no warning until someone re-runs it. Renovate also reads the deprecation from the version taggedlatest, so one unmarked release turns its warning off too.Why a reminder and not an automatic step
This repo publishes through OIDC trusted publishing, and holding no npm token is deliberate. The trusted publisher only grants
npm publishandnpm stage publish, so CI can't runnpm deprecate. A maintainer offireblocks-sdkon npm runs it by hand.Heads-up for the epic owner: DEX-2185's done-criteria ask for this to "re-run automatically on every future publish". That can't be met without a token, so this is a reminder instead.
Order
fireblocks-sdkmaintainer on npm runs the command from the run summary once. That marks every version, including the new one.Any later release before end-of-life gets the same reminder.
Tested
bash -n.🤖 Generated with Claude Code