refactor(config): drive deprecation warnings from config.schema.json

config.schema.json

@@ -372,12 +372,14 @@
     "sslKeyPemPath": {
       "description": "Deprecated: Path to SSL private key file (use tls.key instead)",
       "type": "string",
-      "deprecated": true
+      "deprecated": true,
+      "x-deprecated-replacement": "tls.key"
     },
     "sslCertPemPath": {
       "description": "Deprecated: Path to SSL certificate file (use tls.cert instead)",
       "type": "string",
-      "deprecated": true
+      "deprecated": true,
+      "x-deprecated-replacement": "tls.cert"
     },
     "configurationSources": {
       "enabled": { "type": "boolean" },

src/config/deprecatedFields.ts

@@ -14,27 +14,44 @@
  * limitations under the License.
  */
 
+import _ from 'lodash';
+import schema from '../../config.schema.json';
 import { GitProxyConfig } from './generated/config';
 
+interface SchemaProperty {
+  deprecated?: boolean;
+  'x-deprecated-replacement'?: string;
+}
+
+const schemaProperties = (schema as { properties: Record<string, SchemaProperty> }).properties;
+
+function isSet(value: unknown): boolean {
+  return (
+    value !== undefined && value !== null && (typeof value !== 'string' || value.trim() !== '')
+  );
+}
+
 /**
  * Returns deprecation warnings for legacy top-level config keys in user overrides.
  * PR 3.0 (#1545) will replace warnings with startup failure for legacy-only configs.
  */
 export function getDeprecatedConfigWarnings(userSettings: Partial<GitProxyConfig>): string[] {
+  const settings = userSettings as Record<string, unknown>;
   const warnings: string[] = [];
 
-  if (userSettings.sslKeyPemPath?.trim() && !userSettings.tls?.key?.trim()) {
-    warnings.push('"sslKeyPemPath" is deprecated; use "tls.key" instead (removal in GitProxy 3.0)');
-  }
-
-  if (userSettings.sslCertPemPath?.trim() && !userSettings.tls?.cert?.trim()) {
-    warnings.push(
-      '"sslCertPemPath" is deprecated; use "tls.cert" instead (removal in GitProxy 3.0)',
-    );
-  }
+  for (const [key, property] of Object.entries(schemaProperties)) {
+    if (!property.deprecated || !isSet(settings[key])) {
+      continue;
+    }
 
-  if (typeof userSettings.proxyUrl === 'string' && userSettings.proxyUrl.trim() !== '') {
-    warnings.push('"proxyUrl" is deprecated and ignored; remove it before GitProxy 3.0');
+    const replacement = property['x-deprecated-replacement'];
+    if (!replacement) {
+      warnings.push(`"${key}" is deprecated and ignored; remove it before GitProxy 3.0`);
+    } else if (!isSet(_.get(settings, replacement))) {
+      warnings.push(
+        `"${key}" is deprecated; use "${replacement}" instead (removal in GitProxy 3.0)`,
+      );
+    }
   }
 
   return warnings;

test/deprecatedFields.test.ts

@@ -33,6 +33,27 @@ describe('getDeprecatedConfigWarnings', () => {
     );
   });
 
+  it('warns for a deprecated field that has no replacement', () => {
+    expect(getDeprecatedConfigWarnings({ proxyUrl: 'https://github.com' })).toEqual([
+      '"proxyUrl" is deprecated and ignored; remove it before GitProxy 3.0',
+    ]);
+  });
+
+  it('treats non-string values as set', () => {
+    expect(getDeprecatedConfigWarnings({ proxyUrl: 0 } as never)).toHaveLength(1);
+    expect(getDeprecatedConfigWarnings({ proxyUrl: false } as never)).toHaveLength(1);
+  });
+
+  it('stays quiet when the replacement is already set', () => {
+    expect(
+      getDeprecatedConfigWarnings({
+        sslKeyPemPath: 'key.pem',
+        sslCertPemPath: 'cert.pem',
+        tls: { enabled: true, key: 'k.pem', cert: 'c.pem' },
+      }),
+    ).toEqual([]);
+  });
+
   it('returns no warnings for non-deprecated overrides', () => {
     expect(getDeprecatedConfigWarnings({ uiPort: 9000 })).toEqual([]);
     expect(