Skip to content

Prevent oversized outgoing control frames #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OskarEichler wants to merge 1 commit into from
Closed

Prevent oversized outgoing control frames #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/websocket/driver/hybi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@ def binary(message)
end

def ping(message = '', &callback)
@ping_callbacks[message] = callback if callback
frame(message, :ping)
sent = frame(message, :ping)
@ping_callbacks[message] = callback if sent && callback
sent
end

def pong(message = '')
Expand Down Expand Up @@ -172,6 +173,10 @@ def frame(buffer, type = nil, code = nil)
message.opcode = OPCODES[type]
message.data = payload

if !MESSAGE_OPCODES.include?(message.opcode) && payload.bytesize > 125
raise ArgumentError, 'Control frame payload cannot exceed 125 bytes'
end

if MESSAGE_OPCODES.include?(message.opcode)
message = @extensions.process_outgoing_message(message)
end
Expand Down